Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1015833002: Make mojo and sky dart packages deployable (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make mojo and sky dart packages deployable The packages produced from this CL were deployed as v0.0.1: https://pub.dartlang.org/packages/sky https://pub.dartlang.org/packages/mojo There is still no tool included with the sky package due to pub's inability to run anything other than Dart: https://code.google.com/p/dart/issues/detail?id=22877 I'm likely just going to write a dart version of my "sky" script. :( R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0a0609ae1915256058c4d572590a5138a4f643d0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A sky/sdk/packages/mojo/pubspec.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/sdk/packages/sky/pubspec.yaml View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/tools/deploy_sdk.py View 3 chunks +19 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
ojan
lgtm
5 years, 9 months ago (2015-03-17 18:03:20 UTC) #2
abarth-chromium
https://codereview.chromium.org/1015833002/diff/1/sky/tools/deploy_sdk.py File sky/tools/deploy_sdk.py (right): https://codereview.chromium.org/1015833002/diff/1/sky/tools/deploy_sdk.py#newcode168 sky/tools/deploy_sdk.py:168: sdk_path('packages/sky/sdk_additions/dart_sky.dart')) dart_sky is just a list of parts. We'll ...
5 years, 9 months ago (2015-03-17 18:06:10 UTC) #3
eseidel
5 years, 9 months ago (2015-03-17 18:09:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a0609ae1915256058c4d572590a5138a4f643d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698