Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: gin/array_buffer.h

Issue 101583004: [gin] Turn gin into a component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/arguments.h ('k') | gin/array_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/array_buffer.h
diff --git a/gin/array_buffer.h b/gin/array_buffer.h
index 3169fd021b3b4c2f51b39772f076f5f9b41ac96c..7886fa9be05067c77c55d49e3c01eef4b5f201b0 100644
--- a/gin/array_buffer.h
+++ b/gin/array_buffer.h
@@ -9,6 +9,7 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
#include "gin/converter.h"
+#include "gin/gin_export.h"
#include "v8/include/v8.h"
namespace gin {
@@ -22,12 +23,13 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
static ArrayBufferAllocator* SharedInstance();
};
-class ArrayBuffer {
+class GIN_EXPORT ArrayBuffer {
public:
ArrayBuffer();
explicit ArrayBuffer(v8::Isolate* isolate);
ArrayBuffer(v8::Isolate* isolate, v8::Handle<v8::ArrayBuffer> buffer);
~ArrayBuffer();
+ ArrayBuffer& operator=(const ArrayBuffer& other);
abarth-chromium 2013/12/12 16:41:45 We need to write this operator explicitly?
void* bytes() const { return bytes_; }
size_t num_bytes() const { return num_bytes_; }
@@ -43,12 +45,12 @@ class ArrayBuffer {
};
template<>
-struct Converter<ArrayBuffer> {
+struct GIN_EXPORT Converter<ArrayBuffer> {
static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
ArrayBuffer* out);
};
-class ArrayBufferView {
+class GIN_EXPORT ArrayBufferView {
public:
ArrayBufferView();
ArrayBufferView(v8::Isolate* isolate, v8::Handle<v8::ArrayBufferView> view);
@@ -68,7 +70,7 @@ class ArrayBufferView {
};
template<>
-struct Converter<ArrayBufferView> {
+struct GIN_EXPORT Converter<ArrayBufferView> {
static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
ArrayBufferView* out);
};
« no previous file with comments | « gin/arguments.h ('k') | gin/array_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698