Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 101573004: Hook up GN to the GYP build system. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
bradnelson
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Hook up GN to the GYP build system. This is a reland of 236542 and 238454 (runs GN in GYP mode before actually running GYP), plus some additions Move GYP_DEFINES parsing to Python for GN. I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN. Currently, GN does not produce any files used by the build, these will be added in a second step. BUG=321352 TBR=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238475

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -6 lines) Patch
M build/gyp_chromium View 4 chunks +88 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
7 years ago (2013-12-03 23:14:25 UTC) #1
brettw
Committed patchset #2 manually as r238475 (presubmit successful).
7 years ago (2013-12-03 23:14:53 UTC) #2
trchen
This patch seems to cause many failures. I saw jam and thakis both submitted fix ...
7 years ago (2013-12-04 00:39:52 UTC) #3
Nico
7 years ago (2013-12-04 00:41:14 UTC) #4
Message was sent while issue was closed.
On 2013/12/04 00:39:52, trchen wrote:
> This patch seems to cause many failures. I saw jam and thakis both submitted
fix
> for their use cases. Android's clang bot is still failing.

link?

> 
> I have no idea what this thing does. Is it easy to fix it or revert it?

Powered by Google App Engine
This is Rietveld 408576698