content/browser/frame_host/navigation_controller_impl.cc - Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 101573003: Add the navigation redirect-chain to Sync sessions proto for offline analysis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from creis on patch set 43. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sessions/serialized_navigation_entry_unittest.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 57a92f55a4ee341032d2dc8492133b699d0db368..91f84bf48d77b0acae848f41c25eb41dc2024a35 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -705,7 +705,7 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {

if (params.frame_tree_node_id != -1)

entry->set_frame_tree_node_id(params.frame_tree_node_id);

if (params.redirect_chain.size() > 0)

- entry->set_redirect_chain(params.redirect_chain);

+ entry->SetRedirectChain(params.redirect_chain);

donnd 2014/04/01 18:31:09 We set up the redirect chain here so it will be av

if (params.should_replace_current_entry)

entry->set_should_replace_entry(true);

entry->set_should_clear_history_list(params.should_clear_history_list);

@@ -826,6 +826,7 @@ bool NavigationControllerImpl::RendererDidNavigate(

active_entry->SetTimestamp(timestamp);

active_entry->SetHttpStatusCode(params.http_status_code);

active_entry->SetPageState(params.page_state);

+ active_entry->SetRedirectChain(params.redirects);

// Once it is committed, we no longer need to track several pieces of state on

// the entry.