Add the navigation redirect-chain to Sync sessions proto for offline analysis.

content/browser/frame_host/navigation_entry_impl.h

Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 00287dbea80d761bb2d1c171f7a16eebc90823e3..10b7be386ef4b71d9ad1181e4e40a7f26753f33c 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -86,6 +86,8 @@ class CONTENT_EXPORT NavigationEntryImpl
   virtual void ClearExtraData(const std::string& key) OVERRIDE;
   virtual void SetHttpStatusCode(int http_status_code) OVERRIDE;
   virtual int GetHttpStatusCode() const OVERRIDE;
+  virtual void SetRedirectChain(const std::vector<GURL>& redirects) OVERRIDE;
+  virtual const std::vector<GURL>& GetRedirectChain() const OVERRIDE;
   virtual bool IsRestored() const OVERRIDE;
 
   // Once a navigation entry is committed, we should no longer track several
@@ -193,16 +195,6 @@ class CONTENT_EXPORT NavigationEntryImpl
     should_replace_entry_ = should_replace_entry;
   }
 
-  // Any redirects present in a pending entry when it is transferred from one
-  // process to another.  Not valid after commit.
-  const std::vector<GURL>& redirect_chain() const {
-    return redirect_chain_;
-  }
-
-  void set_redirect_chain(const std::vector<GURL>& redirect_chain) {
-    redirect_chain_ = redirect_chain;
-  }
-
   void SetScreenshotPNGData(scoped_refptr<base::RefCountedBytes> png_data);
   const scoped_refptr<base::RefCountedBytes> screenshot() const {
     return screenshot_;
@@ -258,6 +250,7 @@ class CONTENT_EXPORT NavigationEntryImpl
   bool is_overriding_user_agent_;
   base::Time timestamp_;
   int http_status_code_;
+  std::vector<GURL> redirect_chain_;

[sky, 2014/02/20 22:12:26]

This isn't really persisted via session restore like the rest of these fields,
so I would leave this field where it was with a comment.

[Donn Denman, 2014/02/21 08:18:56]

Done.

 
   // This member is not persisted with session restore because it is transient.
   // If the post request succeeds, this field is cleared since the same
@@ -314,10 +307,6 @@ class CONTENT_EXPORT NavigationEntryImpl
   // doing the redirect).
   bool should_replace_entry_;
 
-  // This is used when transferring a pending entry from one process to another.
-  // It is cleared in |ResetForCommit| and should not be persisted.
-  std::vector<GURL> redirect_chain_;
-
   // This is set to true when this entry's navigation should clear the session
   // history both on the renderer and browser side. The browser side history
   // won't be cleared until the renderer has committed this navigation. This