Issue 101573002: Remove TreatNullAs=NullString for HTMLSelectElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101573002: Remove TreatNullAs=NullString for HTMLSelectElement (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLSelectElement http://whatwg.org/html#htmlselectelement The value attribute returns "" when there is no selected child <option> element, so add another test to verify that null stringifies to "null" on setting. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163087

Patch Set 1 #

Created: 7 years ago

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -7 lines)
M	LayoutTests/fast/dom/domstring-attribute-reflection.html	View	1 chunk	+1 line, -1 line	0 comments
M	LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments
M	LayoutTests/fast/dom/element-attribute-js-null.html	View	1 chunk	+1 line, -1 line	0 comments
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	1 chunk	+1 line, -1 line	0 comments
A	LayoutTests/fast/forms/select-value-null.html	View	1 chunk	+22 lines, -0 lines	0 comments
A	LayoutTests/fast/forms/select-value-null-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments
M	Source/core/html/HTMLSelectElement.idl	View	2 chunks	+2 lines, -2 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101573002/1

7 years ago (2013-12-03 11:58:07 UTC) #3

Message was sent while issue was closed.

Change committed as 163087

Expand Messages | Collapse Messages