Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1015723004: Add option to embed font data into executable. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 8 months ago
Reviewers:
humper, jcgregorio, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add option to embed font data into executable. Some tools would like to be built with all resources embedded. This change makes it possible to build a font manager which uses font data embedded into the executable. Committed: https://skia.googlesource.com/skia/+/5c9fa2844c4f97b9358d547f947372f680c68dd1

Patch Set 1 #

Patch Set 2 : Just do it the portable way. #

Patch Set 3 : Clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -66 lines) Patch
M gyp/common_variables.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/ports.gyp View 1 2 1 chunk +37 lines, -1 line 0 comments Download
M src/ports/SkFontHost_linux.cpp View 1 2 12 chunks +177 lines, -65 lines 0 comments Download
A tools/embed_resources.py View 1 2 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
bungeman-skia
Just wanted to let you guys know I'm working on this and give you a ...
5 years, 9 months ago (2015-03-26 22:11:33 UTC) #2
mtklein
On 2015/03/26 22:11:33, bungeman1 wrote: > Just wanted to let you guys know I'm working ...
5 years, 9 months ago (2015-03-26 22:32:07 UTC) #3
bungeman-skia
On 2015/03/26 22:32:07, mtklein wrote: > On 2015/03/26 22:11:33, bungeman1 wrote: > > Just wanted ...
5 years, 9 months ago (2015-03-27 14:27:15 UTC) #4
jcgregorio
On 2015/03/27 at 14:27:15, bungeman wrote: > On 2015/03/26 22:32:07, mtklein wrote: > > On ...
5 years, 9 months ago (2015-03-27 14:47:06 UTC) #5
bungeman-skia
I think this is fairly straight forward now. Currently (PS3) this just lists Funkster.ttf, since ...
5 years, 8 months ago (2015-03-30 18:44:13 UTC) #7
humper
On 2015/03/30 18:44:13, bungeman1 wrote: > I think this is fairly straight forward now. Currently ...
5 years, 8 months ago (2015-03-30 19:07:41 UTC) #8
bungeman-skia
On 2015/03/30 19:07:41, humper wrote: > On 2015/03/30 18:44:13, bungeman1 wrote: > > I think ...
5 years, 8 months ago (2015-03-30 19:36:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015723004/40001
5 years, 8 months ago (2015-03-30 19:48:50 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 19:53:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5c9fa2844c4f97b9358d547f947372f680c68dd1

Powered by Google App Engine
This is Rietveld 408576698