Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc

Issue 1015723003: Fix content_settings_supervised_provider after deprecation of MEDIASTREAM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_settings/content_settings_supervised_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc b/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
index 46fff91d0906648e76d6d78bf67d8c66961aef01..62d2aff62a5ab89bd2d55f6bf742ef94af0d5da6 100644
--- a/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
@@ -84,19 +84,27 @@ TEST_F(SupervisedUserProviderTest, GeolocationTest) {
TEST_F(SupervisedUserProviderTest, CameraMicTest) {
scoped_ptr<RuleIterator> rule_iterator(provider_->GetRuleIterator(
- CONTENT_SETTINGS_TYPE_MEDIASTREAM, std::string(), false));
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), false));
+ EXPECT_FALSE(rule_iterator->HasNext());
+ rule_iterator.reset();
+ rule_iterator.reset(provider_->GetRuleIterator(
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, std::string(), false));
EXPECT_FALSE(rule_iterator->HasNext());
rule_iterator.reset();
// Disable the default camera and microphone setting.
- EXPECT_CALL(mock_observer_, OnContentSettingChanged(
- _, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM, ""));
+ EXPECT_CALL(mock_observer_,
+ OnContentSettingChanged(
+ _, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, ""));
+ EXPECT_CALL(
+ mock_observer_,
+ OnContentSettingChanged(_, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, ""));
service_.SetLocalSetting(
supervised_users::kCameraMicDisabled,
scoped_ptr<base::Value>(new base::FundamentalValue(true)));
rule_iterator.reset(provider_->GetRuleIterator(
- CONTENT_SETTINGS_TYPE_MEDIASTREAM, std::string(), false));
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), false));
ASSERT_TRUE(rule_iterator->HasNext());
Rule rule = rule_iterator->Next();
EXPECT_FALSE(rule_iterator->HasNext());
@@ -106,15 +114,34 @@ TEST_F(SupervisedUserProviderTest, CameraMicTest) {
EXPECT_EQ(CONTENT_SETTING_BLOCK, ValueToContentSetting(rule.value.get()));
rule_iterator.reset();
+ rule_iterator.reset(provider_->GetRuleIterator(
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, std::string(), false));
+ ASSERT_TRUE(rule_iterator->HasNext());
+ rule = rule_iterator->Next();
+ EXPECT_FALSE(rule_iterator->HasNext());
+
+ EXPECT_EQ(ContentSettingsPattern::Wildcard(), rule.primary_pattern);
+ EXPECT_EQ(ContentSettingsPattern::Wildcard(), rule.secondary_pattern);
+ EXPECT_EQ(CONTENT_SETTING_BLOCK, ValueToContentSetting(rule.value.get()));
+ rule_iterator.reset();
+
// Re-enable the default camera and microphone setting.
- EXPECT_CALL(mock_observer_, OnContentSettingChanged(
- _, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM, ""));
+ EXPECT_CALL(mock_observer_,
+ OnContentSettingChanged(
+ _, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, ""));
+ EXPECT_CALL(
+ mock_observer_,
+ OnContentSettingChanged(_, _, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, ""));
service_.SetLocalSetting(
supervised_users::kCameraMicDisabled,
scoped_ptr<base::Value>(new base::FundamentalValue(false)));
rule_iterator.reset(provider_->GetRuleIterator(
- CONTENT_SETTINGS_TYPE_MEDIASTREAM, std::string(), false));
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), false));
+ EXPECT_FALSE(rule_iterator->HasNext());
+ rule_iterator.reset();
+ rule_iterator.reset(provider_->GetRuleIterator(
+ CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, std::string(), false));
EXPECT_FALSE(rule_iterator->HasNext());
}
« no previous file with comments | « chrome/browser/content_settings/content_settings_supervised_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698