Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1015723003: Fix content_settings_supervised_provider after deprecation of MEDIASTREAM (Closed)

Created:
5 years, 9 months ago by knn
Modified:
5 years, 9 months ago
Reviewers:
msramek, markusheintz_
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content_settings_supervised_provider after deprecation of MEDIASTREAM in favour of _MIC and _CAMERA. BUG=464382 Committed: https://crrev.com/42c2f460d956038bb4e6edfa91ac6385f3905d50 Cr-Commit-Position: refs/heads/master@{#322559}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M chrome/browser/content_settings/content_settings_supervised_provider.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc View 1 2 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
knn
On 2015/03/26 18:46:08, knn wrote: > mailto:knn@chromium.org changed reviewers: > + mailto:markusheintz@chromium.org PTAL.
5 years, 9 months ago (2015-03-26 18:48:58 UTC) #2
markusheintz_
This LG2M. Martin could you also have a look.
5 years, 9 months ago (2015-03-27 10:08:04 UTC) #4
msramek
LGTM. Sorry for introducing so much duplication. But it will soon make sense when we ...
5 years, 9 months ago (2015-03-27 10:18:45 UTC) #5
markusheintz_
On 2015/03/27 10:18:45, msramek wrote: > LGTM. > > Sorry for introducing so much duplication. ...
5 years, 9 months ago (2015-03-27 10:21:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015723003/20001
5 years, 9 months ago (2015-03-27 10:54:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 11:59:20 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 12:00:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42c2f460d956038bb4e6edfa91ac6385f3905d50
Cr-Commit-Position: refs/heads/master@{#322559}

Powered by Google App Engine
This is Rietveld 408576698