Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1015683002: [turbofan] Fix C++ evaluation order in AstGraphBuilder. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix C++ evaluation order in AstGraphBuilder. The evaluation order of receiver versus arguments is not properly defined by C++. This caused issues with Clang where the environment changed after the receiveing environment was already loaded. R=jarin@chromium.org BUG=chromium:467531 TEST=mjsunit/regress/regress-crbug-467531 LOG=N Committed: https://crrev.com/7e8a62e34a827d7d9a505521cdda6ee7c09ee58a Cr-Commit-Position: refs/heads/master@{#27238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M src/compiler/ast-graph-builder.cc View 5 chunks +11 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-467531.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jarin
lgtm
5 years, 9 months ago (2015-03-17 12:14:10 UTC) #1
Michael Starzinger
5 years, 9 months ago (2015-03-17 12:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015683002/1
5 years, 9 months ago (2015-03-17 12:19:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1278)
5 years, 9 months ago (2015-03-17 12:28:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015683002/1
5 years, 9 months ago (2015-03-17 12:31:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 12:37:01 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 12:37:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8a62e34a827d7d9a505521cdda6ee7c09ee58a
Cr-Commit-Position: refs/heads/master@{#27238}

Powered by Google App Engine
This is Rietveld 408576698