[Android WebView] Fix the startup sequence for in-process mode.

[Android WebView] Fix the startup sequence for in-process mode.

The GpuDataManager should be initialized before SetRunRendererInProcess to ensure
the gpu features/blacklists are correctly set for renderer.

BUG=468150
Committed: https://crrev.com/12d25209ace521edb4840bdb18a618d5d7012fca
Cr-Commit-Position: refs/heads/master@{#321258}

[Shouqun, 2015-03-17 11:12:04]

shouqun@chromium.org changed reviewers:
+ boliu@chromium.org

[Shouqun, 2015-03-17 11:14:45]

PTAL, thanks!

[boliu, 2015-03-17 14:15:30]

boliu@chromium.org changed reviewers:
+ sievers@chromium.org

[boliu, 2015-03-17 14:15:31]

I don't know this code. +sievers

> The GpuDataManager should be initialized before SetRunRendererInProcess to
ensure
the gpu features/blacklists are correctly set for renderer.

GpuDataManager after content knows it's running in-process seems like the right
order, since GpuDataManager need to know which CommandLine instance to update.

Otherwise it should make no difference. What exact bug are you trying to fix?

[boliu, 2015-03-17 16:22:41]

On 2015/03/17 14:15:31, boliu wrote:
> I don't know this code. +sievers
> 
> > The GpuDataManager should be initialized before SetRunRendererInProcess to
> ensure
> the gpu features/blacklists are correctly set for renderer.
> 
> GpuDataManager after content knows it's running in-process seems like the
right
> order, since GpuDataManager need to know which CommandLine instance to update.
> 

Ehh, scratch that comment. I thought SetRunRendererInProcess was doing something
else.

> Otherwise it should make no difference. What exact bug are you trying to fix?

Can you point me what is GpuDataManager doing wrong if it comes after
SetRunRendererInProcess?

[no sievers, 2015-03-17 19:10:50]

Can you file a bug explaining the problem?

[Shouqun, 2015-03-18 00:53:10]

On 2015/03/17 19:10:50, sievers wrote:
> Can you file a bug explaining the problem?

@sievers @boliu I have filed a bug to explain the issue (crbug.com/468150),  the
issue is some GPU blacklisted features are not actually blacklisted in Android
WebView, eg, the gpu_rasterization,  if SetRunRendererInProcess get called after
GpuDataManager,  then renderer can't get the correct status of the blacklist.

[boliu, 2015-03-18 01:23:22]

On 2015/03/18 00:53:10, Shouqun wrote:
> On 2015/03/17 19:10:50, sievers wrote:
> > Can you file a bug explaining the problem?
> 
> @sievers @boliu I have filed a bug to explain the issue (crbug.com/468150), 
the
> issue is some GPU blacklisted features are not actually blacklisted in Android
> WebView, eg, the gpu_rasterization,  if SetRunRendererInProcess get called
after
> GpuDataManager,  then renderer can't get the correct status of the blacklist.

Oh. SetRunRendererInProcess calls AppendCompositorCommandLineFlags, which checks
the blacklist and whatnot, so need GpuDataManager to be up.

Hmm, how long has this been broken?

[boliu, 2015-03-18 01:28:27]

I think this change is ok.

On 2015/03/18 01:23:22, boliu wrote:
> On 2015/03/18 00:53:10, Shouqun wrote:
> > On 2015/03/17 19:10:50, sievers wrote:
> > > Can you file a bug explaining the problem?
> > 
> > @sievers @boliu I have filed a bug to explain the issue (crbug.com/468150), 
> the
> > issue is some GPU blacklisted features are not actually blacklisted in
Android
> > WebView, eg, the gpu_rasterization,  if SetRunRendererInProcess get called
> after
> > GpuDataManager,  then renderer can't get the correct status of the
blacklist.
> 
> Oh. SetRunRendererInProcess calls AppendCompositorCommandLineFlags, which
checks
> the blacklist and whatnot, so need GpuDataManager to be up.
> 
> Hmm, how long has this been broken?

Answer might be since webview launched..

[Shouqun, 2015-03-18 01:32:42]

On 2015/03/18 01:23:22, boliu wrote:
> On 2015/03/18 00:53:10, Shouqun wrote:
> > On 2015/03/17 19:10:50, sievers wrote:
> > > Can you file a bug explaining the problem?
> > 
> > @sievers @boliu I have filed a bug to explain the issue (crbug.com/468150), 
> the
> > issue is some GPU blacklisted features are not actually blacklisted in
Android
> > WebView, eg, the gpu_rasterization,  if SetRunRendererInProcess get called
> after
> > GpuDataManager,  then renderer can't get the correct status of the
blacklist.
> 
> Oh. SetRunRendererInProcess calls AppendCompositorCommandLineFlags, which
checks
> the blacklist and whatnot, so need GpuDataManager to be up.
> 
> Hmm, how long has this been broken?

not quite sure about the broken time,  I checked out the trunk code as well as
branch 2311, they are both broken.  I'll check the break point soon

[Shouqun, 2015-03-18 01:38:53]

On 2015/03/18 01:28:27, boliu wrote:
> I think this change is ok.
> 
> On 2015/03/18 01:23:22, boliu wrote:
> > On 2015/03/18 00:53:10, Shouqun wrote:
> > > On 2015/03/17 19:10:50, sievers wrote:
> > > > Can you file a bug explaining the problem?
> > > 
> > > @sievers @boliu I have filed a bug to explain the issue
(crbug.com/468150), 
> > the
> > > issue is some GPU blacklisted features are not actually blacklisted in
> Android
> > > WebView, eg, the gpu_rasterization,  if SetRunRendererInProcess get called
> > after
> > > GpuDataManager,  then renderer can't get the correct status of the
> blacklist.
> > 
> > Oh. SetRunRendererInProcess calls AppendCompositorCommandLineFlags, which
> checks
> > the blacklist and whatnot, so need GpuDataManager to be up.
> > 
> > Hmm, how long has this been broken?
> 
> Answer might be since webview launched..

yes,  I guess so...

[boliu, 2015-03-18 01:40:29]

On 2015/03/18 01:32:42, Shouqun wrote:
> not quite sure about the broken time,  I checked out the trunk code as well as
> branch 2311, they are both broken.  I'll check the break point soon

Not that important. I was just curious. Don't waste too much time on that.

[Shouqun, 2015-03-18 01:43:34]

On 2015/03/18 01:40:29, boliu wrote:
> On 2015/03/18 01:32:42, Shouqun wrote:
> > not quite sure about the broken time,  I checked out the trunk code as well
as
> > branch 2311, they are both broken.  I'll check the break point soon
> 
> Not that important. I was just curious. Don't waste too much time on that.

OK.

[boliu, 2015-03-18 01:47:37]

I don't own this code. So waiting for sievers's review.

Pasting the explanation again:
SetRunRendererInProcess calls AppendCompositorCommandLineFlags, which checks
the blacklist and whatnot, so need GpuDataManager to be up.

[no sievers, 2015-03-18 20:26:14]

lgtm, thanks!

I guess a webview test would be good that checks that both gpu and renderer see
the blacklist settings.

[Shouqun, 2015-03-19 00:11:17]

The CQ bit was checked by shouqun@chromium.org

[commit-bot: I haz the power, 2015-03-19 00:11:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015633003/1

[commit-bot: I haz the power, 2015-03-19 01:02:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-19 01:03:29]

Patchset 1 (id:??) landed as
https://crrev.com/12d25209ace521edb4840bdb18a618d5d7012fca
Cr-Commit-Position: refs/heads/master@{#321258}