chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 1015623007: Changing Option String Resource to lowerCamelcases in handler_options_handler.cc file.

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 1015623007: Changing Option String Resource to lowerCamelcases in handler_options_handler.cc file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/handler_options_list.js ('k') | chrome/browser/ui/webui/options/handler_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

index e21383286f4e12a53ff0e6277ff3fafdba2e29a9..4afd34ef3cb576e88a19500ef242775b39f5d583 100644

--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

@@ -81,21 +81,21 @@ void ClearBrowserDataHandler::GetLocalizedValues(

DCHECK(localized_strings);

static OptionsStringResource resources[] = {

- { "clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL },

- { "contentSettingsAndSearchEnginesRemain",

+ {" clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL },

Bernhard Bauer 2015/04/07 13:25:58 The space should come immediately after the openin

Deepak 2015/04/07 13:32:30 On 2015/04/07 13:25:58, Bernhard Bauer wrote: Don

+ {" contentSettingsAndSearchEnginesRemain",

IDS_CLEAR_BROWSING_DATA_SOME_STUFF_REMAINS },

- { "deleteBrowsingHistoryCheckbox", IDS_DEL_BROWSING_HISTORY_CHKBOX },

- { "deleteDownloadHistoryCheckbox", IDS_DEL_DOWNLOAD_HISTORY_CHKBOX },

- { "deleteCacheCheckbox", IDS_DEL_CACHE_CHKBOX },

- { "deleteCookiesCheckbox", IDS_DEL_COOKIES_CHKBOX },

- { "deleteCookiesFlashCheckbox", IDS_DEL_COOKIES_FLASH_CHKBOX },

- { "deletePasswordsCheckbox", IDS_DEL_PASSWORDS_CHKBOX },

- { "deleteFormDataCheckbox", IDS_DEL_FORM_DATA_CHKBOX },

- { "deleteHostedAppsDataCheckbox", IDS_DEL_HOSTED_APPS_DATA_CHKBOX },

- { "deauthorizeContentLicensesCheckbox",

+ {" deleteBrowsingHistoryCheckbox", IDS_DEL_BROWSING_HISTORY_CHKBOX },

+ {" deleteDownloadHistoryCheckbox", IDS_DEL_DOWNLOAD_HISTORY_CHKBOX },

+ {" deleteCacheCheckbox", IDS_DEL_CACHE_CHKBOX },

+ {" deleteCookiesCheckbox", IDS_DEL_COOKIES_CHKBOX },

+ {" deleteCookiesFlashCheckbox", IDS_DEL_COOKIES_FLASH_CHKBOX },

+ {" deletePasswordsCheckbox", IDS_DEL_PASSWORDS_CHKBOX },

+ {" deleteFormDataCheckbox", IDS_DEL_FORM_DATA_CHKBOX },

+ {" deleteHostedAppsDataCheckbox", IDS_DEL_HOSTED_APPS_DATA_CHKBOX },

+ {" deauthorizeContentLicensesCheckbox",

IDS_DEAUTHORIZE_CONTENT_LICENSES_CHKBOX },

- { "clearBrowserDataCommit", IDS_CLEAR_BROWSING_DATA_COMMIT },

- { "flash_storage_url", IDS_FLASH_STORAGE_URL },

+ {" clearBrowserDataCommit", IDS_CLEAR_BROWSING_DATA_COMMIT },

+ {" flashStorageUrl", IDS_FLASH_STORAGE_URL },

};

RegisterStrings(localized_strings, resources, arraysize(resources));