Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1015623007: Changing Option String Resource to lowerCamelcases in handler_options_handler.cc file. (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing Option String Resource to lowerCamelcases in handler_options_handler.cc file. BUG=470844 Committed: https://crrev.com/733c2692c9ffe090a4bf36abe2edeaffec65af60 Cr-Commit-Position: refs/heads/master@{#324043}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Changes as per review comments. #

Total comments: 2

Patch Set 3 : Changes as per review comments. #

Total comments: 2

Patch Set 4 : Adding space after opening brace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/browser/resources/options/content_settings.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/handler_options.html View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/handler_options_list.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 2 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Deepak
This is for making lowerCamelCase for Option String Resource in handler_options_handler.cc file. PTAL Thanks
5 years, 9 months ago (2015-03-26 12:21:14 UTC) #2
Deepak
This is for making lowerCamelCase for Option String Resource in handler_options_handler.cc file. PTAL Thanks
5 years, 9 months ago (2015-03-26 12:21:18 UTC) #3
Deepak
@Den Beam This is for making lowerCamelCase for Option String Resource in handler_options_handler.cc file. PTAL ...
5 years, 9 months ago (2015-03-27 03:34:55 UTC) #5
Bernhard Bauer
Nice! https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc#newcode84 chrome/browser/ui/webui/options/clear_browser_data_handler.cc:84: {"clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL}, I think I would prefer to ...
5 years, 8 months ago (2015-04-07 09:49:35 UTC) #6
Deepak
Thanks for review. Changes done as suggested. PTAL https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc#newcode84 chrome/browser/ui/webui/options/clear_browser_data_handler.cc:84: {"clearBrowserDataLabel", ...
5 years, 8 months ago (2015-04-07 11:25:14 UTC) #7
Bernhard Bauer
https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): https://codereview.chromium.org/1015623007/diff/1/chrome/browser/ui/webui/options/clear_browser_data_handler.cc#newcode84 chrome/browser/ui/webui/options/clear_browser_data_handler.cc:84: {"clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL}, On 2015/04/07 11:25:13, Deepak wrote: > On ...
5 years, 8 months ago (2015-04-07 11:36:51 UTC) #8
Deepak
Thanks for review.Sorry I missed it. Changes done.. PTAL https://codereview.chromium.org/1015623007/diff/20001/chrome/browser/ui/webui/options/handler_options_handler.cc File chrome/browser/ui/webui/options/handler_options_handler.cc (right): https://codereview.chromium.org/1015623007/diff/20001/chrome/browser/ui/webui/options/handler_options_handler.cc#newcode35 chrome/browser/ui/webui/options/handler_options_handler.cc:35: ...
5 years, 8 months ago (2015-04-07 12:35:21 UTC) #9
Bernhard Bauer
https://codereview.chromium.org/1015623007/diff/40001/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): https://codereview.chromium.org/1015623007/diff/40001/chrome/browser/ui/webui/options/clear_browser_data_handler.cc#newcode84 chrome/browser/ui/webui/options/clear_browser_data_handler.cc:84: {" clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL }, The space should come immediately ...
5 years, 8 months ago (2015-04-07 13:25:58 UTC) #10
Deepak
sorry for my mistake, I hope now it is ok. PTAL. https://codereview.chromium.org/1015623007/diff/40001/chrome/browser/ui/webui/options/clear_browser_data_handler.cc File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right): ...
5 years, 8 months ago (2015-04-07 13:32:30 UTC) #11
Bernhard Bauer
Lovely. LGTM!
5 years, 8 months ago (2015-04-07 13:39:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015623007/60001
5 years, 8 months ago (2015-04-07 14:26:43 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-07 15:19:30 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:21:20 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/733c2692c9ffe090a4bf36abe2edeaffec65af60
Cr-Commit-Position: refs/heads/master@{#324043}

Powered by Google App Engine
This is Rietveld 408576698