chrome/common/extensions/permissions/chrome_permission_message_rules.cc - Issue 1015623005: chrome.settingsPrivate: Basic stub implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 1015623005: chrome.settingsPrivate: Basic stub implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update the permission message Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | extensions/browser/extension_function_histogram_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

index 8cfe9e71b396e835d3951cef44a0506097936a5f..da8d65a020322c7be01e2c6d5d6d142f59e70d99 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

@@ -454,9 +454,7 @@ ChromePermissionMessageRule::GetAllRules() {

{IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,

{APIPermission::kManagement},

{}},

- {IDS_EXTENSION_PROMPT_WARNING_MDNS,

- {APIPermission::kMDns},

- {}},

+ {IDS_EXTENSION_PROMPT_WARNING_MDNS, {APIPermission::kMDns}, {}},

{IDS_EXTENSION_PROMPT_WARNING_NATIVE_MESSAGING,

{APIPermission::kNativeMessaging},

{}},

@@ -496,6 +494,9 @@ ChromePermissionMessageRule::GetAllRules() {

{IDS_EXTENSION_PROMPT_WARNING_MUSIC_MANAGER_PRIVATE,

{APIPermission::kMusicManagerPrivate},

{}},

+ {IDS_EXTENSION_PROMPT_WARNING_SETTINGS_PRIVATE,

+ {APIPermission::kSettingsPrivate},

+ {}},

// Platform-app permission messages.