Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 1015613003: MIPS: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 if (IC::ICUseVector(kind())) { 712 if (IC::ICUseVector(kind())) {
713 PushVectorAndSlot(); 713 PushVectorAndSlot();
714 } 714 }
715 715
716 FrontendHeader(receiver(), name, &miss); 716 FrontendHeader(receiver(), name, &miss);
717 717
718 // Get the value from the cell. 718 // Get the value from the cell.
719 Register result = StoreDescriptor::ValueRegister(); 719 Register result = StoreDescriptor::ValueRegister();
720 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell); 720 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
721 __ LoadWeakValue(result, weak_cell, &miss); 721 __ LoadWeakValue(result, weak_cell, &miss);
722 __ ld(result, FieldMemOperand(result, Cell::kValueOffset)); 722 __ ld(result, FieldMemOperand(result, PropertyCell::kValueOffset));
723 723
724 // Check for deleted property if property can actually be deleted. 724 // Check for deleted property if property can actually be deleted.
725 if (is_configurable) { 725 if (is_configurable) {
726 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 726 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
727 __ Branch(&miss, eq, result, Operand(at)); 727 __ Branch(&miss, eq, result, Operand(at));
728 } 728 }
729 729
730 Counters* counters = isolate()->counters(); 730 Counters* counters = isolate()->counters();
731 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3); 731 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3);
732 if (IC::ICUseVector(kind())) { 732 if (IC::ICUseVector(kind())) {
733 DiscardVectorAndSlot(); 733 DiscardVectorAndSlot();
734 } 734 }
735 __ Ret(USE_DELAY_SLOT); 735 __ Ret(USE_DELAY_SLOT);
736 __ mov(v0, result); 736 __ mov(v0, result);
737 737
738 FrontendFooter(name, &miss); 738 FrontendFooter(name, &miss);
739 739
740 // Return the generated code. 740 // Return the generated code.
741 return GetCode(kind(), Code::NORMAL, name); 741 return GetCode(kind(), Code::NORMAL, name);
742 } 742 }
743 743
744 744
745 #undef __ 745 #undef __
746 } 746 }
747 } // namespace v8::internal 747 } // namespace v8::internal
748 748
749 #endif // V8_TARGET_ARCH_MIPS64 749 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698