Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 1015613003: MIPS: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 if (IC::ICUseVector(kind())) { 711 if (IC::ICUseVector(kind())) {
712 PushVectorAndSlot(); 712 PushVectorAndSlot();
713 } 713 }
714 714
715 FrontendHeader(receiver(), name, &miss); 715 FrontendHeader(receiver(), name, &miss);
716 716
717 // Get the value from the cell. 717 // Get the value from the cell.
718 Register result = StoreDescriptor::ValueRegister(); 718 Register result = StoreDescriptor::ValueRegister();
719 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell); 719 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
720 __ LoadWeakValue(result, weak_cell, &miss); 720 __ LoadWeakValue(result, weak_cell, &miss);
721 __ lw(result, FieldMemOperand(result, Cell::kValueOffset)); 721 __ lw(result, FieldMemOperand(result, PropertyCell::kValueOffset));
722 722
723 // Check for deleted property if property can actually be deleted. 723 // Check for deleted property if property can actually be deleted.
724 if (is_configurable) { 724 if (is_configurable) {
725 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 725 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
726 __ Branch(&miss, eq, result, Operand(at)); 726 __ Branch(&miss, eq, result, Operand(at));
727 } 727 }
728 728
729 Counters* counters = isolate()->counters(); 729 Counters* counters = isolate()->counters();
730 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3); 730 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3);
731 if (IC::ICUseVector(kind())) { 731 if (IC::ICUseVector(kind())) {
732 DiscardVectorAndSlot(); 732 DiscardVectorAndSlot();
733 } 733 }
734 __ Ret(USE_DELAY_SLOT); 734 __ Ret(USE_DELAY_SLOT);
735 __ mov(v0, result); 735 __ mov(v0, result);
736 736
737 FrontendFooter(name, &miss); 737 FrontendFooter(name, &miss);
738 738
739 // Return the generated code. 739 // Return the generated code.
740 return GetCode(kind(), Code::NORMAL, name); 740 return GetCode(kind(), Code::NORMAL, name);
741 } 741 }
742 742
743 743
744 #undef __ 744 #undef __
745 } 745 }
746 } // namespace v8::internal 746 } // namespace v8::internal
747 747
748 #endif // V8_TARGET_ARCH_MIPS 748 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698