Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: remoting/webapp/crd/js/gnubby_auth_handler.js

Issue 1015553003: Added more typechecking functions and unit tests for existing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/client_plugin_impl.js ('k') | remoting/webapp/crd/js/host.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/gnubby_auth_handler.js
diff --git a/remoting/webapp/crd/js/gnubby_auth_handler.js b/remoting/webapp/crd/js/gnubby_auth_handler.js
index f3514dde2620a9b6099f97e88db235e8410b40e6..724bbdc0a7ab0c4032cee47a2460c627fda3f6f4 100644
--- a/remoting/webapp/crd/js/gnubby_auth_handler.js
+++ b/remoting/webapp/crd/js/gnubby_auth_handler.js
@@ -62,12 +62,12 @@ remoting.GnubbyAuthHandler.prototype.sendMessageToHost_ = function(data) {
*/
remoting.GnubbyAuthHandler.prototype.onExtensionMessage =
function(type, message) {
- var messageType = getStringAttr(message, 'type');
+ var messageType = base.getStringAttr(message, 'type');
if (messageType == 'data') {
this.sendMessageToGnubbyd_({
'type': 'auth-agent@openssh.com',
- 'data': getArrayAttr(message, 'data')
- }, this.callback_.bind(this, getNumberAttr(message, 'connectionId')));
+ 'data': base.getArrayAttr(message, 'data')
+ }, this.callback_.bind(this, base.getNumberAttr(message, 'connectionId')));
} else {
console.error('Invalid gnubby-auth message: ' + messageType);
return false;
@@ -87,7 +87,7 @@ remoting.GnubbyAuthHandler.prototype.callback_ =
this.sendMessageToHost_({
'type': 'data',
'connectionId': connectionId,
- 'data': getArrayAttr(response, 'data')
+ 'data': base.getArrayAttr(response, 'data')
});
} catch (/** @type {*} */ err) {
console.error('gnubby callback failed: ', err);
« no previous file with comments | « remoting/webapp/crd/js/client_plugin_impl.js ('k') | remoting/webapp/crd/js/host.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698