Added more typechecking functions and unit tests for existing code.

remoting/webapp/crd/js/host_list_api_impl.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * REST API for host-list management.
  */
 
 /** @suppress {duplicate} */
@@ skipping 97 matching lines @@
     var obj = /** @type {{data: {items: Array}}} */
         (base.jsonParseSafe(response.getText()));
     if (!obj || !obj.data) {
       console.error('Invalid "hosts" response from server.');
       onError(remoting.Error.unexpected());
     } else {
       var items = obj.data.items || [];
       var hosts = items.map(
         function(/** Object */ item) {
           var host = new remoting.Host();
-          host.hostName = getStringAttr(item, 'hostName', '');
-          host.hostId = getStringAttr(item, 'hostId', '');
-          host.status = getStringAttr(item, 'status', '');
-          host.jabberId = getStringAttr(item, 'jabberId', '');
-          host.publicKey = getStringAttr(item, 'publicKey', '');
-          host.hostVersion = getStringAttr(item, 'hostVersion', '');
-          host.tokenUrlPatterns = getArrayAttr(item, 'tokenUrlPatterns', []);
-          host.updatedTime = getStringAttr(item, 'updatedTime', '');
-          host.hostOfflineReason = getStringAttr(item, 'hostOfflineReason', '');
+          host.hostName = base.getStringAttr(item, 'hostName', '');
+          host.hostId = base.getStringAttr(item, 'hostId', '');
+          host.status = base.getStringAttr(item, 'status', '');
+          host.jabberId = base.getStringAttr(item, 'jabberId', '');
+          host.publicKey = base.getStringAttr(item, 'publicKey', '');
+          host.hostVersion = base.getStringAttr(item, 'hostVersion', '');
+          host.tokenUrlPatterns =
+              base.getArrayAttr(item, 'tokenUrlPatterns', []);
+          host.updatedTime = base.getStringAttr(item, 'updatedTime', '');
+          host.hostOfflineReason =
+              base.getStringAttr(item, 'hostOfflineReason', '');
           return host;
       });
       onDone(hosts);
     }
   } else {
     onError(remoting.Error.fromHttpStatus(response.status));
   }
 };
 
 /** @type {remoting.HostListApi} */
 remoting.hostListApi = new remoting.HostListApiImpl();
 
 })();