Added more typechecking functions and unit tests for existing code.

remoting/webapp/crd/js/gnubby_auth_handler.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class that routes gnubby-auth extension messages to and from the gnubbyd
  * extension.
  */
 
@@ skipping 35 matching lines @@
  */
 remoting.GnubbyAuthHandler.prototype.sendMessageToHost_ = function(data) {
   this.sendMessageToHostCallback_(this.getType(), JSON.stringify(data));
 }
 
 /**
  * Processes gnubby-auth messages.
  * @param {string} data The gnubby-auth message data.
  */
 remoting.GnubbyAuthHandler.prototype.onMessage = function(data) {
-  var message = getJsonObjectFromString(data);
-  var messageType = getStringAttr(message, 'type');
+  var message = base.getJsonObjectFromString(data);
+  var messageType = base.getStringAttr(message, 'type');
   if (messageType == 'data') {
     this.sendMessageToGnubbyd_({
       'type': 'auth-agent@openssh.com',
-      'data': getArrayAttr(message, 'data')
-    }, this.callback_.bind(this, getNumberAttr(message, 'connectionId')));
+      'data': base.getArrayAttr(message, 'data')
+    }, this.callback_.bind(this, base.getNumberAttr(message, 'connectionId')));
   } else {
     console.error('Invalid gnubby-auth message: ' + messageType);
   }
 };
 
 /**
  * Callback invoked with data to be returned to the host.
  * @param {number} connectionId The connection id.
  * @param {Object} response The JSON response with the data to send to the host.
  * @private
  */
 remoting.GnubbyAuthHandler.prototype.callback_ =
     function(connectionId, response) {
   try {
     this.sendMessageToHost_({
       'type': 'data',
       'connectionId': connectionId,
-      'data': getArrayAttr(response, 'data')
+      'data': base.getArrayAttr(response, 'data')
     });
   } catch (/** @type {*} */ err) {
     console.error('gnubby callback failed: ', err);
     this.sendMessageToHost_({
       'type': 'error',
       'connectionId': connectionId
     });
     return;
   }
 };
@@ skipping 26 matching lines @@
  */
 function onGnubbydDevReply_(jsonObject, callback, reply) {
   var kGnubbydStableExtensionId = 'beknehfpfkghjoafdifaflglpjkojoco';
 
   if (reply) {
     callback(reply);
   } else {
     chrome.runtime.sendMessage(kGnubbydStableExtensionId, jsonObject, callback);
   }
 }