Added more typechecking functions and unit tests for existing code.

remoting/webapp/crd/js/it2me_host_facade.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class to communicate with the It2me Host component via Native Messaging.
  */
 
 /** @suppress {duplicate} */
@@ skipping 190 matching lines @@
 
 /**
  * Handler for incoming messages.
  *
  * @param {Object} message The received message.
  * @return {void}
  * @private
  */
 remoting.It2MeHostFacade.prototype.onIncomingMessage_ =
     function(message) {
-  var type = getStringAttr(message, 'type');
+  var type = base.getStringAttr(message, 'type');
 
   switch (type) {
     case 'helloResponse':
-      var version = getStringAttr(message, 'version');
+      var version = base.getStringAttr(message, 'version');
       console.log('Host version: ', version);
       this.initialized_ = true;
       // A "hello" request is sent immediately after the native messaging host
       // is started. We can proceed to the next task once we receive the
       // "helloReponse".
       if (this.onInitialized_) {
         this.onInitialized_();
       }
       break;
 
     case 'connectResponse':
       console.log('connectResponse received');
       // Response to the "connect" request. No action is needed until we
       // receive the corresponding "hostStateChanged" message.
       break;
 
     case 'disconnectResponse':
       console.log('disconnectResponse received');
       // Response to the "disconnect" request. No action is needed until we
       // receive the corresponding "hostStateChanged" message.
       break;
 
     case 'hostStateChanged':
-      var stateString = getStringAttr(message, 'state');
+      var stateString = base.getStringAttr(message, 'state');
       console.log('hostStateChanged received: ', stateString);
       var state = remoting.HostSession.State.fromString(stateString);
 
       switch (state) {
         case remoting.HostSession.State.RECEIVED_ACCESS_CODE:
-          var accessCode = getStringAttr(message, 'accessCode');
-          var accessCodeLifetime = getNumberAttr(message, 'accessCodeLifetime');
+          var accessCode = base.getStringAttr(message, 'accessCode');
+          var accessCodeLifetime =
+              base.getNumberAttr(message, 'accessCodeLifetime');
           this.onReceivedAccessCode_(accessCode, accessCodeLifetime);
           break;
 
         case remoting.HostSession.State.CONNECTED:
-          var client = getStringAttr(message, 'client');
+          var client = base.getStringAttr(message, 'client');
           this.onConnected_(client);
           break;
       }
       if (this.onStateChanged_) {
         this.onStateChanged_(state);
       }
       break;
 
     case 'natPolicyChanged':
       if (this.onNatPolicyChanged_) {
         var natTraversalEnabled =
-            getBooleanAttr(message, 'natTraversalEnabled');
+            base.getBooleanAttr(message, 'natTraversalEnabled');
         this.onNatPolicyChanged_(natTraversalEnabled);
       }
       break;
 
     case 'error':
-      console.error(getStringAttr(message, 'description'));
+      console.error(base.getStringAttr(message, 'description'));
       if (this.onError_) {
         this.onError_(remoting.Error.unexpected());
       }
       break;
 
     default:
       throw 'Unexpected native message: ' + message;
   }
 };
 
@@ skipping 34 matching lines @@
                 chrome.runtime.lastError.message);
     this.onInitializationFailed_();
   } else {
     console.error('Native Messaging port disconnected.');
     this.port_ = null;
     this.onError_(remoting.Error.unexpected());
   }
 };
 
 })();