Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1015533019: Add settings:: namespace to MdSettingsUi. (Closed)

Created:
5 years, 9 months ago by Kyle Horimoto
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MdSettingsUi to its own directory. There will be additional settings-related files in the near future, so this directory will be used to organize them. BUG= Committed: https://crrev.com/150f086c1cc91090378a61556d58b70fd53dc32d Cr-Commit-Position: refs/heads/master@{#322279}

Patch Set 1 #

Patch Set 2 : Added settings/ directory per jhawkins@'s request. #

Patch Set 3 : Edited .gypi file. #

Patch Set 4 : Builds successfully. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -99 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/md_settings_ui.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/md_settings_ui.cc View 1 1 chunk +0 lines, -64 lines 0 comments Download
A + chrome/browser/ui/webui/settings/md_settings_ui.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Kyle Horimoto
5 years, 9 months ago (2015-03-25 22:17:09 UTC) #2
Kyle Horimoto
5 years, 9 months ago (2015-03-25 22:24:36 UTC) #4
James Hawkins
Why is this necessary?
5 years, 9 months ago (2015-03-25 22:26:58 UTC) #5
Kyle Horimoto
On 2015/03/25 22:26:58, James Hawkins wrote: > Why is this necessary? It helps to organize ...
5 years, 9 months ago (2015-03-25 22:30:16 UTC) #6
James Hawkins
If we're going to be adding more files (which it sounds like we are), then ...
5 years, 9 months ago (2015-03-25 22:42:55 UTC) #7
Kyle Horimoto
On 2015/03/25 22:42:55, James Hawkins wrote: > If we're going to be adding more files ...
5 years, 9 months ago (2015-03-25 23:04:50 UTC) #8
James Hawkins
lgtm
5 years, 9 months ago (2015-03-25 23:07:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533019/50001
5 years, 9 months ago (2015-03-25 23:25:19 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 9 months ago (2015-03-26 00:47:12 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:47:53 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/150f086c1cc91090378a61556d58b70fd53dc32d
Cr-Commit-Position: refs/heads/master@{#322279}

Powered by Google App Engine
This is Rietveld 408576698