Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1015533014: Disabled metro mode launch for Windows 10, until there some clarity on technical details. (Closed)

Created:
5 years, 9 months ago by Shrikant Kelkar
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled metro mode launch for Windows 10, until there is some clarity on technical details. Note: You can still launch and test using either --force-immersive command line or by pressing Shift+F11 magic key just after launching chrome through shortcut. BUG=470227 R=cpu,ananta Committed: https://crrev.com/a96f46b821b7c9400ffb14462ad87c33be547407 Cr-Commit-Position: refs/heads/master@{#324363}

Patch Set 1 #

Patch Set 2 : Enabled force mode (desktop/metro) on Windows 10. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Shrikant Kelkar
5 years, 9 months ago (2015-03-24 20:01:31 UTC) #1
cpu_(ooo_6.6-7.5)
Like hidding the menu, but we should allow some way for launching it, so we ...
5 years, 9 months ago (2015-03-26 20:13:33 UTC) #2
Shrikant Kelkar
On 2015/03/26 20:13:33, cpu wrote: > Like hidding the menu, but we should allow some ...
5 years, 9 months ago (2015-03-26 20:32:15 UTC) #3
Shrikant Kelkar
On 2015/03/26 20:32:15, Shrikant Kelkar wrote: > On 2015/03/26 20:13:33, cpu wrote: > > Like ...
5 years, 8 months ago (2015-04-01 21:14:19 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-04-09 00:42:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533014/20001
5 years, 8 months ago (2015-04-09 00:53:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/41140) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-09 01:05:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533014/40001
5 years, 8 months ago (2015-04-09 02:02:20 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 04:11:03 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 04:11:54 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a96f46b821b7c9400ffb14462ad87c33be547407
Cr-Commit-Position: refs/heads/master@{#324363}

Powered by Google App Engine
This is Rietveld 408576698