Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1015533011: remove colorfilter native-565 support. complicating w/ no real value. (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove colorfilter native-565 support. complicating w/ no real value. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -136 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +3 lines, -19 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkModeColorFilter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkColorFilter.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M src/core/SkFilterShader.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkFilterShader.cpp View 2 chunks +4 lines, -15 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 5 chunks +10 lines, -44 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +1 line, -38 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533011/1
5 years, 9 months ago (2015-03-24 01:42:29 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 01:42:30 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCE-NoGPU-x86_64-Debug-Trybot/builds/64) Test-Ubuntu-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 9 months ago (2015-03-24 01:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533011/20001
5 years, 9 months ago (2015-03-24 02:15:22 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 02:15:23 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-24 08:15:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533011/20001
5 years, 9 months ago (2015-03-24 10:50:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710
5 years, 9 months ago (2015-03-24 10:50:26 UTC) #13
reed1
5 years, 9 months ago (2015-03-24 12:17:49 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1022673007/ by reed@google.com.

The reason for reverting is: skia/ext/benchmarking_canvas.cc references
HasFilter16 :(.

Powered by Google App Engine
This is Rietveld 408576698