Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1015533007: [Password manager Python tests] Add a comment on logging (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
Reviewers:
battre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager Python tests] Add a comment on logging This CL adds a comment on how logging is used to report script and test failures. R=battre@chromium.org BUG=468245 Committed: https://crrev.com/992e7cfc8657512d4a283250c8ad99c2c2950ad7 Cr-Commit-Position: refs/heads/master@{#321346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/test/data/password_manager/automated_tests/run_tests.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vabr (Chromium)
Hi Dominic, PTAL. Note: This comments is for the test framework script developer, not for ...
5 years, 9 months ago (2015-03-19 12:14:26 UTC) #1
battre
lgtm
5 years, 9 months ago (2015-03-19 12:19:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015533007/1
5 years, 9 months ago (2015-03-19 12:24:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:27:58 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:28:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/992e7cfc8657512d4a283250c8ad99c2c2950ad7
Cr-Commit-Position: refs/heads/master@{#321346}

Powered by Google App Engine
This is Rietveld 408576698