Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Issue 1015523005: [Webapp Refactor] Implements AppConnectedView. (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Implements AppConnectedView. App remoting relies on the onVideoStreamingStarted() to determine whether it should hide the loading window and show the remote app. In the existing implementation, onVideoStreamingStarted() is invoked in remoting.DesktopViewport which is not part of the shared code. This CL moves that logic into AppConnectedView. BUG=465878 Committed: https://crrev.com/7fd718c468244b485cec8f660e04e10a35b433be Cr-Commit-Position: refs/heads/master@{#321455}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -70 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/webapp/app_remoting/js/app_connected_view.js View 1 chunk +106 lines, -0 lines 1 comment Download
M remoting/webapp/app_remoting/js/app_remoting.js View 4 chunks +2 lines, -30 lines 0 comments Download
M remoting/webapp/base/js/application.js View 2 chunks +0 lines, -19 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 chunk +0 lines, -9 lines 0 comments Download
M remoting/webapp/crd/js/desktop_viewport.js View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kelvinp
PTAL https://codereview.chromium.org/1015523005/diff/1/remoting/webapp/app_remoting/js/app_connected_view.js File remoting/webapp/app_remoting/js/app_connected_view.js (right): https://codereview.chromium.org/1015523005/diff/1/remoting/webapp/app_remoting/js/app_connected_view.js#newcode35 remoting/webapp/app_remoting/js/app_connected_view.js:35: var pingTimer = new base.RepeatingTimer(function () { Moved ...
5 years, 9 months ago (2015-03-19 21:19:21 UTC) #2
garykac
lgtm
5 years, 9 months ago (2015-03-19 21:26:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015523005/1
5 years, 9 months ago (2015-03-19 21:37:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 22:36:11 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:36:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fd718c468244b485cec8f660e04e10a35b433be
Cr-Commit-Position: refs/heads/master@{#321455}

Powered by Google App Engine
This is Rietveld 408576698