Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1015523004: Remove the hack for print preview scrolling added in https://codereview.chromium.org/912433002 (Closed)

Created:
5 years, 9 months ago by raymes
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the hack for print preview scrolling added in https://codereview.chromium.org/912433002 The bug (crbug.com/455439) has now been fixed. BUG=455430 Committed: https://crrev.com/be21df0558aa1d555abf17a0ae7bf8e972f3cb46 Cr-Commit-Position: refs/heads/master@{#321236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/resources/print_preview/previewarea/margin_control.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
5 years, 9 months ago (2015-03-16 22:50:33 UTC) #2
raymes
5 years, 9 months ago (2015-03-18 02:29:21 UTC) #4
majidvp
lgtm
5 years, 9 months ago (2015-03-18 12:33:45 UTC) #5
Aleksey Shlyapnikov
lgtm
5 years, 9 months ago (2015-03-18 18:11:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015523004/1
5 years, 9 months ago (2015-03-18 22:54:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 23:45:05 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 23:46:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be21df0558aa1d555abf17a0ae7bf8e972f3cb46
Cr-Commit-Position: refs/heads/master@{#321236}

Powered by Google App Engine
This is Rietveld 408576698