Fix for issue 22780 - print the stack trace on OOM and Stack overflow exceptions too.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 13451 matching lines @@
 }
 
 
 void UnhandledException::set_stacktrace(const Instance& stacktrace) const {
   StorePointer(&raw_ptr()->stacktrace_, stacktrace.raw());
 }
 
 
 const char* UnhandledException::ToErrorCString() const {
   Isolate* isolate = Isolate::Current();
-  if (exception() == isolate->object_store()->out_of_memory()) {
-    return "Unhandled exception:\nOut of memory";
-  }
-  if (exception() == isolate->object_store()->stack_overflow()) {
-    return "Unhandled exception:\nStack overflow";
-  }
   HANDLESCOPE(isolate);
   Object& strtmp = Object::Handle();
-  const Instance& exc = Instance::Handle(exception());
-  strtmp = DartLibraryCalls::ToString(exc);
-  const char* exc_str =
-      "<Received error while converting exception to string>";
-  if (!strtmp.IsError()) {
-    exc_str = strtmp.ToCString();
+  const char* exc_str;
+  if (exception() == isolate->object_store()->out_of_memory()) {
+    exc_str = "Out of Memory";
+  } else if (exception() == isolate->object_store()->stack_overflow()) {
+    exc_str = "Stack Overflow";
+  } else {
+    const Instance& exc = Instance::Handle(exception());
+    strtmp = DartLibraryCalls::ToString(exc);
+    if (!strtmp.IsError()) {
+      exc_str = strtmp.ToCString();
+    } else {
+      exc_str = "<Received error while converting exception to string>";
+    }
   }
   const Instance& stack = Instance::Handle(stacktrace());
   strtmp = DartLibraryCalls::ToString(stack);
   const char* stack_str =
       "<Received error while converting stack trace to string>";
   if (!strtmp.IsError()) {
     stack_str = strtmp.ToCString();
   }
-
   const char* format = "Unhandled exception:\n%s\n%s";
-  int len = (strlen(exc_str) + strlen(stack_str) + strlen(format)
-             - 4    // Two '%s'
-             + 1);  // '\0'
+  intptr_t len = OS::SNPrint(NULL, 0, format, exc_str, stack_str);
   char* chars = isolate->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, format, exc_str, stack_str);
   return chars;
 }
 
 
 const char* UnhandledException::ToCString() const {
   return "UnhandledException";
 }
 
@@ skipping 7247 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart