Raise a RemoteDeviceException when appurify reports an exception.

Raise a RemoteDeviceException when appurify reports an exception.

Currently, if appurify reports an exception, we will report it in
the way we report test failures. Instead, we should be raising a
RemoteDeviceException.

BUG=

Committed: https://crrev.com/05b0457fb4f12a4b9fa94e6a2a92d10f3de6feb0
Cr-Commit-Position: refs/heads/master@{#321863}

[mikecase (-- gone --), 2015-03-16 21:38:07]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2015-03-16 21:38:08]

Currently, if appurify reports an exception we treat it like a test failure. As
you can see for example...

C  300.444s Main  [==========] 1 test ran.
C  300.444s Main  [  PASSED  ] 0 tests.
C  300.444s Main  [  FAILED  ] 1 test, listed below:
C  300.445s Main  [  FAILED  ] 1011: Cannot connect to VM 172.22.21.69:22
T065002G48 

Changed it to raise an exception instead.

Here are the list of appurify exceptions if you are interested.
https://appurify.atlassian.net/wiki/display/APD/Exception+Messages

[jbudorick, 2015-03-16 21:40:50]

Note that this only addresses gtests -- what about instrumentation tests?
Perhaps there's some way we could address this generally in
remote_device_test_run.py?

https://codereview.chromium.org/1015513005/diff/1/build/android/pylib/remote/...
File build/android/pylib/remote/device/remote_device_gtest_run.py (right):

https://codereview.chromium.org/1015513005/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_gtest_run.py:77: raise
remote_device_helper.RemoteDeviceError(
I'm not sure if this will always be an error that should be classified as an
infra failure, but I'm ok with landing it and going from there.

[mikecase (-- gone --), 2015-03-16 22:16:51]

Moved the code for checking if there was an appurify exception to
remote_device_test_run.

https://codereview.chromium.org/1015513005/diff/1/build/android/pylib/remote/...
File build/android/pylib/remote/device/remote_device_gtest_run.py (right):

https://codereview.chromium.org/1015513005/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_gtest_run.py:77: raise
remote_device_helper.RemoteDeviceError(
On 2015/03/16 21:40:50, jbudorick wrote:
> I'm not sure if this will always be an error that should be classified as an
> infra failure, but I'm ok with landing it and going from there.

I looked through the list of possible exceptions, and it seemed like pretty much
all of them are infra related. There are a few that deal with using bad config
files, and those aren't really infra related, but thats it.

[jbudorick, 2015-03-23 17:51:38]

lgtm

[mikecase (-- gone --), 2015-03-23 19:30:40]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-03-23 19:31:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015513005/20001

[commit-bot: I haz the power, 2015-03-23 21:42:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 21:43:34]

Patchset 2 (id:??) landed as
https://crrev.com/05b0457fb4f12a4b9fa94e6a2a92d10f3de6feb0
Cr-Commit-Position: refs/heads/master@{#321863}