Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: content/browser/frame_host/render_frame_host_impl_browsertest.cc

Issue 1015493004: Disable RenderFrameHostImplBrowserTest.GetVisibilityState_Basic on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_impl_browsertest.cc b/content/browser/frame_host/render_frame_host_impl_browsertest.cc
index f80f7eea4bfb06bcd122f03d81362d1699919a09..a704d16c78f7b56b50da7cd5a864ac09b4741661 100644
--- a/content/browser/frame_host/render_frame_host_impl_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_impl_browsertest.cc
@@ -114,8 +114,14 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest, IsFocused_Widget) {
// Test that a frame is visible/hidden depending on its WebContents visibility
// state.
+// Flaky on Mac. http://crbug.com/467670
+#if defined(OS_MACOSX)
+#define MAYBE_GetVisibilityState_Basic DISABLED_GetVisibilityState_Basic
+#else
+#define MAYBE_GetVisibilityState_Basic GetVisibilityState_Basic
+#endif
IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,
- GetVisibilityState_Basic) {
+ MAYBE_GetVisibilityState_Basic) {
EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,foo")));
WebContents* web_contents = shell()->web_contents();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698