Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1015493002: [Files.app] Reenable TraverseSlideImagesOnDownloads tests (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
hirono, yawano
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Reenable TraverseSlideImagesOnDownloads tests According to the issue (crbug.com/437293), the root issue is solved. Then we need to re-enable the disabled tests. This patch does it. BUG=437293 TEST=browsertest passes R=hirono@chromium.org, yawano@chromium.org Committed: https://crrev.com/397663a2d96e717a4b33aee7f60651adb3e2a135 Cr-Commit-Position: refs/heads/master@{#320867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yoshiki
@hirono, @yawano, these tests have been disabled for some reason after the root cause is ...
5 years, 9 months ago (2015-03-16 18:16:42 UTC) #3
yoshiki
FYI: I ran them 10 times locally but can't observe failure.
5 years, 9 months ago (2015-03-16 18:17:32 UTC) #4
hirono
lgtm, thanks!
5 years, 9 months ago (2015-03-16 23:56:39 UTC) #5
yawano
lgtm too. Thank you!
5 years, 9 months ago (2015-03-17 00:57:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015493002/1
5 years, 9 months ago (2015-03-17 04:48:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 04:52:09 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 04:53:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/397663a2d96e717a4b33aee7f60651adb3e2a135
Cr-Commit-Position: refs/heads/master@{#320867}

Powered by Google App Engine
This is Rietveld 408576698