Issue 1015473002: Revert of fix for invalid for loop syntax broke build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1015473002: Revert of fix for invalid for loop syntax broke build (Closed)

Created:
5 years, 9 months ago by egdaniel

Modified:
5 years, 9 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/) Reason for revert: needed to revert early patch Original issue's description: > fix for invalid for loop syntax broke build > NOTREECHECKS=true > NOTRY=true > TBR= > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fdc310855dbf04ffb33787f5c0d76fef90b303d4 TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d18475854ce232de71c5463e0654f459d4abfd43

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/codec/SkCodec.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

egdaniel

Created Revert of fix for invalid for loop syntax broke build

5 years, 9 months ago (2015-03-16 17:49:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015473002/1

5 years, 9 months ago (2015-03-16 17:50:07 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 17:50:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d18475854ce232de71c5463e0654f459d4abfd43