[Audio Player] Cleanup the code along with closure compiler

ui/file_manager/audio_player/js/audio_player_model.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-(function(global) {
+/**
+ * The model class for audio player.
+ * @constructor
+ */
+function AudioPlayerModel() {
   'use strict';
 
   /**
    * List of values to be stored into the model.
-   * @type {Object<string, *>}
+   * @type {!Object<string, *>}
    * @const
    */
-  var VALUES = Object.freeze({
-    shuffle: false,
-    repeat: false,
-    volume: 100,
-    expanded: false,
-  });
+  var VALUES = Object.freeze(
+    /**
+     * They will be used as properties of AudioPlayerModel.
+     * @lends {AudioPlayerModel.prototype}
+     */
+    {
+      shuffle: false,
+      repeat: false,
+      volume: 100,
+      expanded: false,
+    });
 
   /**
    * Prefix of the stored values in the storage.
    * @type {string}
    */
   var STORAGE_PREFIX = 'audioplayer-';
 
-  /**
-   * Save the values in the model into the storage.
-   * @param {AudioPlayerModel} model The model.
-   */
-  function saveModel(model) {
-    var objectToBeSaved = {};
-    for (var key in VALUES) {
-      objectToBeSaved[STORAGE_PREFIX + key] = model[key];
-    }
+    /**
+     * Save the values in the model into the storage.
+     * @param {AudioPlayerModel} model The model.
+     */
+    function saveModel(model) {
+      var objectToBeSaved = {};

[fukino, 2015/03/17 06:32:44]

nit: incorrect indentation

[yoshiki, 2015/03/17 08:28:06]

Done.

+      for (var key in VALUES) {
+        objectToBeSaved[STORAGE_PREFIX + key] = model[key];
+      }
 
     chrome.storage.local.set(objectToBeSaved);
   };
 
   /**
    * Load the values in the model from the storage.
    * @param {AudioPlayerModel} model The model.
    * @param {function()} callback Called when the load is completed.
    */
   function loadModel(model, callback) {
     // Restores the values from the storage
     var objectsToBeRead = Object.keys(VALUES).
                           map(function(a) {
                             return STORAGE_PREFIX + a;
                           });
 
     chrome.storage.local.get(objectsToBeRead, function(result) {
       for (var key in result) {
         // Strips the prefix.
         model[key.substr(STORAGE_PREFIX.length)] = result[key];
       }
       callback();
-    });
+    }.bind(this));

[fukino, 2015/03/17 06:32:44]

nit: is this bind() necessary?

[yoshiki, 2015/03/17 08:28:06]

Done.

   };
 
-  /**
-   * The model class for audio player.
-   * @constructor
-   */
-  function AudioPlayerModel() {
-    // Initializes values.
-    for (var key in VALUES) {
-      this[key] = VALUES[key];
-    }
-    Object.seal(this);
+  // Initializes values.
+  for (var key in VALUES) {
+    this[key] = VALUES[key];
+  }
+  Object.seal(this);
 
-    // Restores the values from the storage
-    var target = this;
-    loadModel(target, function() {
-      // Installs observer to watch changes of the values.
-      Object.observe(target, function(changes) {
-        saveModel(target);
-      });
+  // Restores the values from the storage
+  var target = this;
+  loadModel(target, function() {
+    // Installs observer to watch changes of the values.
+    Object.observe(target, function(changes) {
+      saveModel(target);
     });
-  }
-
-  // Exports AudioPlayerModel class to the global.
-  global.AudioPlayerModel = AudioPlayerModel;
-
-})(this || window);
+  });
+}