Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1015463006: [Audio Player] Cleanup the code along with closure compiler (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Audio Player] Cleanup the code along with closure compiler To pass the code with the closure compiler, this patch reformats the code, adds the annotation, and fixes some of the minor bugs. R=fukino@chromium.org BUG=448263 TEST=browsertest passes Committed: https://crrev.com/c9e9edb58d81cd63d211c6166f9092d161149b45 Cr-Commit-Position: refs/heads/master@{#320882}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -76 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.js View 3 chunks +17 lines, -6 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 5 chunks +24 lines, -11 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.js View 4 chunks +13 lines, -5 lines 0 comments Download
M ui/file_manager/audio_player/elements/volume_controller.js View 3 chunks +18 lines, -7 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 7 chunks +12 lines, -16 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_model.js View 1 2 2 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yoshiki
@fukinoi-san, PTAL. Thanks
5 years, 9 months ago (2015-03-17 05:19:19 UTC) #2
fukino
Thanks! lgtm with nits. https://codereview.chromium.org/1015463006/diff/20001/ui/file_manager/audio_player/js/audio_player_model.js File ui/file_manager/audio_player/js/audio_player_model.js (right): https://codereview.chromium.org/1015463006/diff/20001/ui/file_manager/audio_player/js/audio_player_model.js#newcode40 ui/file_manager/audio_player/js/audio_player_model.js:40: var objectToBeSaved = {}; nit: ...
5 years, 9 months ago (2015-03-17 06:32:44 UTC) #3
yoshiki
Thanks https://codereview.chromium.org/1015463006/diff/20001/ui/file_manager/audio_player/js/audio_player_model.js File ui/file_manager/audio_player/js/audio_player_model.js (right): https://codereview.chromium.org/1015463006/diff/20001/ui/file_manager/audio_player/js/audio_player_model.js#newcode40 ui/file_manager/audio_player/js/audio_player_model.js:40: var objectToBeSaved = {}; On 2015/03/17 06:32:44, fukino ...
5 years, 9 months ago (2015-03-17 08:28:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015463006/40001
5 years, 9 months ago (2015-03-17 08:28:17 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 09:17:35 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 09:18:35 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9e9edb58d81cd63d211c6166f9092d161149b45
Cr-Commit-Position: refs/heads/master@{#320882}

Powered by Google App Engine
This is Rietveld 408576698