Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/dom_distiller/distiller_viewer.cc

Issue 1015463004: Consistent content placement method for dom-distiller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix IOS version of code Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/dom_distiller/distiller_viewer.cc
diff --git a/ios/chrome/browser/dom_distiller/distiller_viewer.cc b/ios/chrome/browser/dom_distiller/distiller_viewer.cc
index bf30950290303c6a3d4115fdb5eac1a290cf37f5..9a6f745297e15040bf51c6b03a087fa1516333ac 100644
--- a/ios/chrome/browser/dom_distiller/distiller_viewer.cc
+++ b/ios/chrome/browser/dom_distiller/distiller_viewer.cc
@@ -38,8 +38,8 @@ DistillerViewer::~DistillerViewer() {
void DistillerViewer::OnArticleReady(
const DistilledArticleProto* article_proto) {
- const std::string html = viewer::GetUnsafeArticleHtml(
- article_proto, distilled_page_prefs_->GetTheme(),
+ const std::string html = viewer::GetUnsafeArticleTemplateHtml(
+ &article_proto->pages(0), distilled_page_prefs_->GetTheme(),
cjhopman 2015/03/27 00:45:15 It looks like your change will make it so iOS does
cjhopman 2015/03/27 00:48:33 I don't see the code that uses this for iOS (maybe
mdjones 2015/03/30 23:12:27 Done, but this should be considered a temporary fi
mdjones 2015/03/30 23:12:27 Acknowledged.
distilled_page_prefs_->GetFontFamily());
callback_.Run(url_, html);
« no previous file with comments | « components/dom_distiller/core/viewer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698