Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1015443002: Defer setting "internalinstanceid" so that pending (and destroyed) (Closed)

Created:
5 years, 9 months ago by lazyboy
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Defer setting "internalinstanceid" so that pending (and destroyed) browser plugins can detach before we attach again. BUG=467614 Test=Load a <webview> Set its style.display = 'block'. Observer that it succeeds without <webview> going stale or throwing any error about "attach" failing. Committed: https://crrev.com/cbbe20f81b775fb77d545127e6f9771c08a12508 Cr-Commit-Position: refs/heads/master@{#320803}

Patch Set 1 #

Patch Set 2 : clean up a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +24 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
FYI, all WebViewTest.* seems to pass locally, I've sent a trybot run to check all ...
5 years, 9 months ago (2015-03-16 19:24:05 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-16 20:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015443002/20001
5 years, 9 months ago (2015-03-16 22:07:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 22:11:39 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:12:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbbe20f81b775fb77d545127e6f9771c08a12508
Cr-Commit-Position: refs/heads/master@{#320803}

Powered by Google App Engine
This is Rietveld 408576698