Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2192)

Issue 1015433003: Don't handle out-of-range parameters for arcs in UnalteredParsing mode (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't handle out-of-range parameters for arcs in UnalteredParsing mode This means that pathSegList actually keeps/presents the out-of-range parameters. (This behavior matches Gecko.) BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191990

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -26 lines) Patch
M LayoutTests/svg/dom/path-parser-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/script-tests/path-parser.js View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 2 chunks +18 lines, -22 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 9 months ago (2015-03-16 18:53:29 UTC) #2
kouhei (in TOK)
lgtm https://codereview.chromium.org/1015433003/diff/1/Source/core/svg/SVGPathParser.cpp File Source/core/svg/SVGPathParser.cpp (right): https://codereview.chromium.org/1015433003/diff/1/Source/core/svg/SVGPathParser.cpp#newcode253 Source/core/svg/SVGPathParser.cpp:253: Nit: Might want to add ASSERT(m_pathParsingMode == NormalizedParsing)? ...
5 years, 9 months ago (2015-03-17 01:57:46 UTC) #4
fs
Thanks for the review! https://codereview.chromium.org/1015433003/diff/1/Source/core/svg/SVGPathParser.cpp File Source/core/svg/SVGPathParser.cpp (right): https://codereview.chromium.org/1015433003/diff/1/Source/core/svg/SVGPathParser.cpp#newcode253 Source/core/svg/SVGPathParser.cpp:253: On 2015/03/17 01:57:46, kouhei wrote: ...
5 years, 9 months ago (2015-03-17 09:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015433003/1
5 years, 9 months ago (2015-03-17 09:29:00 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 09:32:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191990

Powered by Google App Engine
This is Rietveld 408576698