Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101543004: Revert of Revert "Revert 237280 "Remove TraceController"" (Closed)

Created:
7 years ago by Xianzhu
Modified:
7 years ago
Reviewers:
CC:
chromium-reviews, paulirish+reviews_chromium.org, vsevik, jam, aandrey+blink_chromium.org, yurys, joi+watch-content_chromium.org, dsinclair+watch_chromium.org, robertshield, devtools-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/99103004/ Reason for revert: Bug 323749 still unresolved TBR= NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1669 lines, -578 lines) Patch
M base/debug/trace_event_impl.h View 8 chunks +56 lines, -11 lines 0 comments Download
M base/debug/trace_event_impl.cc View 24 chunks +150 lines, -86 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 11 chunks +35 lines, -13 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 5 chunks +44 lines, -18 lines 0 comments Download
M chrome/browser/feedback/feedback_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +8 lines, -17 lines 0 comments Download
M chrome/browser/feedback/tracing_manager.h View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/feedback/tracing_manager.cc View 6 chunks +24 lines, -15 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +26 lines, -8 lines 0 comments Download
M chrome/test/base/tracing.cc View 6 chunks +30 lines, -50 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/tracing/child_trace_message_filter.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M components/tracing/tracing_messages.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/android/tracing_controller_android.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/tracing_controller_android.cc View 3 chunks +46 lines, -21 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 5 chunks +32 lines, -80 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/tracing/trace_controller_impl.h View 1 chunk +105 lines, -0 lines 0 comments Download
A content/browser/tracing/trace_controller_impl.cc View 1 chunk +371 lines, -0 lines 0 comments Download
M content/browser/tracing/trace_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 8 chunks +15 lines, -8 lines 0 comments Download
A content/browser/tracing/trace_subscriber_stdio.h View 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/tracing/trace_subscriber_stdio.cc View 1 chunk +201 lines, -0 lines 0 comments Download
A content/browser/tracing/trace_subscriber_stdio_unittest.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 5 chunks +12 lines, -27 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 16 chunks +64 lines, -138 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A content/public/browser/trace_controller.h View 1 chunk +107 lines, -0 lines 0 comments Download
A content/public/browser/trace_subscriber.h View 1 chunk +43 lines, -0 lines 0 comments Download
M content/public/browser/tracing_controller.h View 9 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Xianzhu
Created Revert of Revert "Revert 237280 "Remove TraceController""
7 years ago (2013-12-03 17:29:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/101543004/1
7 years ago (2013-12-03 17:30:09 UTC) #2
commit-bot: I haz the power
Change committed as 238424
7 years ago (2013-12-03 17:31:37 UTC) #3
Xianzhu
7 years ago (2013-12-03 18:35:09 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/102003003/ by wangxianzhu@chromium.org.

The reason for reverting is: Not the real reason of test failure. Reapply..

Powered by Google App Engine
This is Rietveld 408576698