Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1015393002: Files.app: Add fade animation on toggling checkmarks on grid view. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add fade animation on toggling checkmarks on grid view. BUG=464122 TEST=manually checked. Committed: https://crrev.com/1399b83a85eeba2b949ec008210ff56e49b2e105 Cr-Commit-Position: refs/heads/master@{#321312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +17 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 9 months ago (2015-03-19 06:50:48 UTC) #2
yawano
lgtm. Thank you!
5 years, 9 months ago (2015-03-19 07:23:55 UTC) #3
fukino
On 2015/03/19 07:23:55, yawano wrote: > lgtm. Thank you! Thank you for quick review!
5 years, 9 months ago (2015-03-19 07:27:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015393002/1
5 years, 9 months ago (2015-03-19 07:27:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 07:58:55 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 08:00:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1399b83a85eeba2b949ec008210ff56e49b2e105
Cr-Commit-Position: refs/heads/master@{#321312}

Powered by Google App Engine
This is Rietveld 408576698