Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1015353004: [turbofan] Eliminatable JS/call nodes should not have a control input. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminatable JS/call nodes should not have a control input. The control input is only relevant for operations that may "write" (to prevent hoisting) or "throw" (because they are part of the control chain). R=jarin@chromium.org Committed: https://crrev.com/ed082f2adc013bcd958ca334fc5eda05a4747257 Cr-Commit-Position: refs/heads/master@{#27288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/operator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-19 07:24:43 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-19 07:25:07 UTC) #2
Jarin
lgtm. (nit: eliminatable -> eliminable?)
5 years, 9 months ago (2015-03-19 07:29:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015353004/1
5 years, 9 months ago (2015-03-19 07:31:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 07:47:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 07:48:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed082f2adc013bcd958ca334fc5eda05a4747257
Cr-Commit-Position: refs/heads/master@{#27288}

Powered by Google App Engine
This is Rietveld 408576698