Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1015353003: Revert of Add a chromium based simple QUIC client. (Closed)

Created:
5 years, 9 months ago by jackhou1
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a chromium based simple QUIC client. (patchset #10 id:180001 of https://codereview.chromium.org/995423003/) Reason for revert: Failed compile on IOS: http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/273 http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/24069 Original issue's description: > Add a chromium based simple QUIC client. > > Committed: https://crrev.com/04730a11c0a58a338bccc006c5cdbccc2607185e > Cr-Commit-Position: refs/heads/master@{#321303} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9e077bba7eaedc5485b5e67ba1188ff9b1145108 Cr-Commit-Position: refs/heads/master@{#321304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -418 lines) Patch
M net/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M net/spdy/spdy_http_utils.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 9 chunks +61 lines, -64 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 4 chunks +248 lines, -210 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 7 chunks +14 lines, -17 lines 0 comments Download
M net/tools/quic/quic_simple_client_session.h View 4 chunks +10 lines, -10 lines 0 comments Download
M net/tools/quic/quic_simple_client_session.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M net/tools/quic/quic_simple_client_stream.h View 7 chunks +13 lines, -15 lines 0 comments Download
M net/tools/quic/quic_simple_client_stream.cc View 7 chunks +24 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jackhou1
Created Revert of Add a chromium based simple QUIC client.
5 years, 9 months ago (2015-03-19 06:17:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015353003/1
5 years, 9 months ago (2015-03-19 06:17:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 06:18:04 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 06:18:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e077bba7eaedc5485b5e67ba1188ff9b1145108
Cr-Commit-Position: refs/heads/master@{#321304}

Powered by Google App Engine
This is Rietveld 408576698