Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 101533007: IDL compiler: [InitializedByEventConstructor] (basic) (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [InitializedByEventConstructor] (basic) Lotta special cases for this too, to do in followups. BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterfaceEventConstructor.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-09 07:28:05 UTC) #1
haraken
LGTM
7 years ago (2013-12-09 07:29:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/101533007/1
7 years ago (2013-12-09 07:30:00 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 07:30:11 UTC) #4
Message was sent while issue was closed.
Change committed as 163402

Powered by Google App Engine
This is Rietveld 408576698