Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 101533003: Simplify the Incognito NTP. (Closed)

Created:
7 years ago by palmer
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Simplify the Incognito NTP. Reduce the amount of text. BUG=70664 TEST=none R=somast@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239282

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use Glen's language, +"browser's" to distinguish from server-side state. #

Patch Set 3 : Fix typo and re-add missing linebreak. #

Patch Set 4 : Keep the <ph name="BEGIN_BOLD"> and <ph name="END_BOLD">. #

Patch Set 5 : Do the <ph name="BEGIN_BOLD"> correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
palmer
Anyone else who should take a look at this?
7 years ago (2013-12-04 01:52:46 UTC) #1
felt
On 2013/12/04 01:52:46, Chromium Palmer wrote: > Anyone else who should take a look at ...
7 years ago (2013-12-04 02:01:55 UTC) #2
palmer
OK, I'll poke the text in that way tomorrow. Somas, thoughts or feelings?
7 years ago (2013-12-04 02:06:15 UTC) #3
somast
lgtm but can you run it by glen@ since he opened this bug? On Tue, ...
7 years ago (2013-12-04 23:53:57 UTC) #4
palmer
Glen: We crave to learn your feelings and thoughts!
7 years ago (2013-12-05 18:16:54 UTC) #5
nyquist
How about https://code.google.com/p/chromium/issues/detail?id=70664#c57 ?
7 years ago (2013-12-05 18:59:18 UTC) #6
battre
https://codereview.chromium.org/101533003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/101533003/diff/1/chrome/app/generated_resources.grd#oldcode10985 chrome/app/generated_resources.grd:10985: <ph name="BEGIN_BOLD">&lt;strong&gt;</ph>You've gone incognito<ph name="END_BOLD">"&lt;/strong&gt;</ph>. Pages you view in ...
7 years ago (2013-12-06 09:36:24 UTC) #7
palmer
> Besides Tommy's pointer to Glen's version, I am concerned about the statement on > ...
7 years ago (2013-12-06 20:41:08 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-07 00:24:22 UTC) #9
palmer
Committed patchset #5 manually as r239282 (presubmit successful).
7 years ago (2013-12-07 00:38:14 UTC) #10
felt
On 2013/12/07 00:38:14, Chromium Palmer wrote: > Committed patchset #5 manually as r239282 (presubmit successful). ...
7 years ago (2013-12-07 04:45:19 UTC) #11
battre
On 2013/12/07 04:45:19, felt wrote: > On 2013/12/07 00:38:14, Chromium Palmer wrote: > > Committed ...
7 years ago (2013-12-09 14:35:00 UTC) #12
palmer
It's Glen's string, so I think he approves. (He approved the Android side of this ...
7 years ago (2013-12-09 19:43:59 UTC) #13
felt
On 2013/12/09 19:43:59, Chromium Palmer wrote: > It's Glen's string, so I think he approves. ...
7 years ago (2013-12-09 21:56:49 UTC) #14
palmer
7 years ago (2013-12-10 00:30:20 UTC) #15
Message was sent while issue was closed.
> Maybe this would be worth bringing up in the Incognito meeting on Wed?

Agree.

Powered by Google App Engine
This is Rietveld 408576698