|
|
Created:
7 years ago by palmer Modified:
7 years ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionSimplify the Incognito NTP.
Reduce the amount of text.
BUG=70664
TEST=none
R=somast@google.com
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239282
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use Glen's language, +"browser's" to distinguish from server-side state. #Patch Set 3 : Fix typo and re-add missing linebreak. #Patch Set 4 : Keep the <ph name="BEGIN_BOLD"> and <ph name="END_BOLD">. #Patch Set 5 : Do the <ph name="BEGIN_BOLD"> correctly. #
Messages
Total messages: 15 (0 generated)
Anyone else who should take a look at this?
On 2013/12/04 01:52:46, Chromium Palmer wrote: > Anyone else who should take a look at this? This change needs to go through UI review. Unclear if it needs to go through go/no-go (ask Somas). While you're at it, can I request another change. Something like: "Going incognito doesn't affect the behavior of other people, servers, or software." --> "<b>Going incognito doesn't protect you from websites, malicious software, or nosy network administrators.</b> It just keeps your history clean!"
OK, I'll poke the text in that way tomorrow. Somas, thoughts or feelings?
lgtm but can you run it by glen@ since he opened this bug? On Tue, Dec 3, 2013 at 6:06 PM, <palmer@chromium.org> wrote: > OK, I'll poke the text in that way tomorrow. > > Somas, thoughts or feelings? > > https://codereview.chromium.org/101533003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Glen: We crave to learn your feelings and thoughts!
https://codereview.chromium.org/101533003/diff/1/chrome/app/generated_resourc... File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/101533003/diff/1/chrome/app/generated_resourc... chrome/app/generated_resources.grd:10985: <ph name="BEGIN_BOLD"><strong></ph>You've gone incognito<ph name="END_BOLD">"</strong></ph>. Pages you view in this window won't appear in your browser history or search history, and they won't leave other traces, like cookies, on your computer after you close <strong>all</strong> open incognito windows. Any files you download or bookmarks you create will be preserved, however. Besides Tommy's pointer to Glen's version, I am concerned about the statement on "search history". If you log in to your search engine, stuff goes into your server side search history.
> Besides Tommy's pointer to Glen's version, I am concerned about the statement on > "search history". If you log in to your search engine, stuff goes into your > server side search history. I want to keep the brevity, and I think that the "does not affect other software... servers..." should explain it. But, I did add "browser's" before the list of example state objects, so that hopefully clarifies things a bit.
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Message was sent while issue was closed.
Committed patchset #5 manually as r239282 (presubmit successful).
Message was sent while issue was closed.
On 2013/12/07 00:38:14, Chromium Palmer wrote: > Committed patchset #5 manually as r239282 (presubmit successful). I'm still a little uncomfortable with the chosen string. We've taken away the explanation of what Incognito *doesn't* prevent, and I don't think the phrase "the behavior of other people, servers, software, or people standing behind you" adequately replaces it (if I didn't already know what it meant, I'd have no idea what that means).
Message was sent while issue was closed.
On 2013/12/07 04:45:19, felt wrote: > On 2013/12/07 00:38:14, Chromium Palmer wrote: > > Committed patchset #5 manually as r239282 (presubmit successful). > > I'm still a little uncomfortable with the chosen string. We've taken away the > explanation of what Incognito *doesn't* prevent, and I don't think the phrase > "the behavior of other people, servers, software, or people standing behind you" > adequately replaces it (if I didn't already know what it meant, I'd have no idea > what that means). I am not 100% sure whether this CL is an improvement either. We now have an even larger blob of text. Did you check with UI?
Message was sent while issue was closed.
It's Glen's string, so I think he approves. (He approved the Android side of this CL.) I think the string is perfectly clear about what Incognito does and doesn't do. If a user wonders, "Does this mean ad companies can't track me?" they can see that "Going incognito doesn't affect the behavior of other people, servers, software..." answers that question. And we affirmatively state that Incognito *does* prevent incognito browsing from going into your browser history. It no longer says, "Be wary [whatever that is supposed to mean], of ..." which I think is an improvement. If the blob of text is too big, we can break it up into multiple paragraphs. We could get rid of the "people standing behind you part", which we intend humorously but which (IMHO) starts to sound sarcastic. But really, people pay attention to the name "Incognito" and the Spy Guy icon, and people draw incorrect conclusions from there. As you know I have proposed fixing that.
Message was sent while issue was closed.
On 2013/12/09 19:43:59, Chromium Palmer wrote: > It's Glen's string, so I think he approves. (He approved the Android side of > this CL.) > > I think the string is perfectly clear about what Incognito does and doesn't do. > If a user wonders, "Does this mean ad companies can't track me?" they can see > that "Going incognito doesn't affect the behavior of other people, servers, > software..." answers that question. And we affirmatively state that Incognito > *does* prevent incognito browsing from going into your browser history. > > It no longer says, "Be wary [whatever that is supposed to mean], of ..." which I > think is an improvement. > > If the blob of text is too big, we can break it up into multiple paragraphs. We > could get rid of the "people standing behind you part", which we intend > humorously but which (IMHO) starts to sound sarcastic. > > But really, people pay attention to the name "Incognito" and the Spy Guy icon, > and people draw incorrect conclusions from there. As you know I have proposed > fixing that. Maybe this would be worth bringing up in the Incognito meeting on Wed?
Message was sent while issue was closed.
> Maybe this would be worth bringing up in the Incognito meeting on Wed? Agree. |