Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1015273002: Add back the truncation of scroll_delta (Closed)

Created:
5 years, 9 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back the truncation of scroll_delta Keep this hack until fractional scrolling with fixed-pos layer works correctly. BUG=468513 Committed: https://crrev.com/d799dd2f08bc21b822b9d8a6c8cbbd62d510f499 Cr-Commit-Position: refs/heads/master@{#321293}

Patch Set 1 #

Patch Set 2 : fix unittests #

Patch Set 3 : fix webview test #

Total comments: 2

Patch Set 4 : remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +14 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 5 chunks +6 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yufeng Shen (Slow to review)
5 years, 9 months ago (2015-03-19 00:49:50 UTC) #2
aelias_OOO_until_Jul13
lgtm
5 years, 9 months ago (2015-03-19 02:29:40 UTC) #3
Yufeng Shen (Slow to review)
+ boliu@ for android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
5 years, 9 months ago (2015-03-19 03:03:01 UTC) #5
boliu
lgtm https://codereview.chromium.org/1015273002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java (right): https://codereview.chromium.org/1015273002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java#newcode232 android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java:232: nit: remove blank line
5 years, 9 months ago (2015-03-19 03:07:59 UTC) #6
Yufeng Shen (Slow to review)
https://codereview.chromium.org/1015273002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java (right): https://codereview.chromium.org/1015273002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java#newcode232 android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java:232: On 2015/03/19 03:07:59, boliu wrote: > nit: remove blank ...
5 years, 9 months ago (2015-03-19 03:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015273002/60001
5 years, 9 months ago (2015-03-19 03:17:47 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-19 04:23:28 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:24:16 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d799dd2f08bc21b822b9d8a6c8cbbd62d510f499
Cr-Commit-Position: refs/heads/master@{#321293}

Powered by Google App Engine
This is Rietveld 408576698