Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1015253002: Default box-sizing to border-box (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Default box-sizing to border-box content-box is crazy banana-pants. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eaed3fa56e553de5aae888823529b0a05dc9d3f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/popup_menu.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-18 22:23:21 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-18 22:50:05 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-19 17:55:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaed3fa56e553de5aae888823529b0a05dc9d3f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698