Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1015243004: Move load progress tracking logic to the frame tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index fa4756f9295e39f18092e40708ef6a3f7af7a65a..c3b57e5132bba31b3fd0581b63b9d63c221deb13 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -90,15 +90,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
: public RenderFrameHost,
public BrowserAccessibilityDelegate {
public:
- // These values indicate the loading progress status. The minimum progress
- // value matches what Blink's ProgressTracker has traditionally used for a
- // minimum progress value.
- // TODO(fdegans): Move these values to the implementation when the relevant
- // IPCs are moved from WebContentsImpl to RenderFrameHost.
- static const double kLoadingProgressNotStarted;
- static const double kLoadingProgressMinimum;
- static const double kLoadingProgressDone;
-
// Keeps track of the state of the RenderFrameHostImpl, particularly with
// respect to swap out.
enum RenderFrameHostImplState {
@@ -218,16 +209,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
// call FrameTreeNode::IsLoading.
bool is_loading() const { return is_loading_; }
- // Sets this RenderFrameHost's loading progress (from 0 to 1).
- void set_loading_progress(double loading_progress) {
- loading_progress_ = loading_progress;
- }
-
- // Returns this RenderFrameHost's loading progress. This is only used by
- // FrameTreeNode. The proper way to check a frame loading progress is to call
- // FrameTreeNode::GetLoadingProgress.
- double loading_progress() const { return loading_progress_; }
-
// This returns the RenderFrameHost's owned RenderWidgetHost if it has one,
// or else it returns nullptr.
// If the RenderFrameHost is the page's main frame, this returns instead a
@@ -700,9 +681,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
// document or not.
bool is_loading_;
- // Used to track this RenderFrameHost's loading progress (from 0 to 1).
- double loading_progress_;
-
// Used to swap out or shut down this RFH when the unload event is taking too
// long to execute, depending on the number of active frames in the
// SiteInstance.

Powered by Google App Engine
This is Rietveld 408576698