Issue 101523002: Remove deprecated Persistent::MakeWeak usage from V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101523002: Remove deprecated Persistent::MakeWeak usage from V8 (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)

Modified:
7 years ago

Reviewers:
dcarney, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove deprecated Persistent::MakeWeak usage from V8 BUG=none LOG=n R=dcarney@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18227

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+349 lines, -322 lines)			Patch
M	src/d8.cc	View	2 chunks	+21 lines, -13 lines	0 comments	Download
M	test/cctest/test-api.cc	View	25 chunks	+321 lines, -303 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r18227 (presubmit successful).

7 years ago (2013-12-03 10:40:19 UTC) #3

Sven Panne

7 years ago (2013-12-03 15:36:50 UTC) #4

Message was sent while issue was closed.

On 2013/12/03 10:40:19, jochen wrote:
> Committed patchset #1 manually as r18227 (presubmit successful).

Hmmm, all those handwritten variants of std::pair are overkill IMHO, but well...
:-/ Closing https://codereview.chromium.org/98993002/

Expand Messages | Collapse Messages