Let text contexts fall back directly to paths

Let text contexts fall back directly to paths

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6e8cd9671958c69babde9338c5c18a4c3d895575

[joshualitt, 2015-03-18 18:49:54]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, jvanverth@google.com, robertphillips@google.com

[joshualitt, 2015-03-18 18:49:55]

Most of the change is in textcontext.cpp's base class

[robertphillips, 2015-03-18 19:52:14]

looks good to me but I would prefer to have Jim also chime in.

https://codereview.chromium.org/1015173002/diff/20001/src/gpu/GrTextContext.h
File src/gpu/GrTextContext.h (right):

https://codereview.chromium.org/1015173002/diff/20001/src/gpu/GrTextContext.h...
src/gpu/GrTextContext.h:45: // text.  We might be able to move this logic to
context though.
// Note: this is unreffed ?

https://codereview.chromium.org/1015173002/diff/20001/src/gpu/GrTextContext.h...
src/gpu/GrTextContext.h:68: 
skPaint -> origPaint ?

https://codereview.chromium.org/1015173002/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (left):

https://codereview.chromium.org/1015173002/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1829: // this will just call our drawPath()
Can we simplify drawText_asPaths and/or drawPosText_asPaths now?

[joshualitt, 2015-03-18 19:58:46]

Patchset #3 (id:40001) has been deleted

[jvanverth1, 2015-03-18 22:25:25]

https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
src/gpu/GrDistanceFieldTextContext.cpp:370:
fFallbackTextContext->onDrawPosText(rt, clip, paint, skPaint, viewMatrix,
This concerns me. It removes the check as to whether the fallback can draw this.
It's a little unclear what will happen if it can't.

[joshualitt, 2015-03-19 14:38:42]

On 2015/03/18 22:25:25, jvanverth1 wrote:
>
https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
> File src/gpu/GrDistanceFieldTextContext.cpp (right):
> 
>
https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
> src/gpu/GrDistanceFieldTextContext.cpp:370:
> fFallbackTextContext->onDrawPosText(rt, clip, paint, skPaint, viewMatrix,
> This concerns me. It removes the check as to whether the fallback can draw
this.
> It's a little unclear what will happen if it can't.

Okay, so I've updated the CL to pass around the regionclipbounds so we can call
drawText/drawPosText on the fallback text context

[jvanverth1, 2015-03-19 17:06:08]

On 2015/03/19 14:38:42, joshualitt wrote:
> On 2015/03/18 22:25:25, jvanverth1 wrote:
> >
>
https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
> > File src/gpu/GrDistanceFieldTextContext.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1015173002/diff/60001/src/gpu/GrDistanceField...
> > src/gpu/GrDistanceFieldTextContext.cpp:370:
> > fFallbackTextContext->onDrawPosText(rt, clip, paint, skPaint, viewMatrix,
> > This concerns me. It removes the check as to whether the fallback can draw
> this.
> > It's a little unclear what will happen if it can't.
> 
> Okay, so I've updated the CL to pass around the regionclipbounds so we can
call
> drawText/drawPosText on the fallback text context

LGTM

[joshualitt, 2015-03-19 17:06:49]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-03-19 17:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015173002/100001

[commit-bot: I haz the power, 2015-03-19 17:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 17:07:11]

Presubmit check for 1015173002-100001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[joshualitt, 2015-03-19 17:11:00]

joshualitt@google.com changed reviewers:
+ reed@google.com

[joshualitt, 2015-03-19 17:11:23]

On 2015/03/19 17:07:11, I haz the power (commit-bot) wrote:
> Presubmit check for 1015173002-100001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Since the CL is editing public API, you must have an LGTM from one of:
> (mailto:, mailto:, mailto:,
> mailto:, mailto:, mailto:)

Mike, can I get an lgtm for the changes to SkPaint?

[joshualitt, 2015-03-20 14:46:58]

On 2015/03/19 17:11:23, joshualitt wrote:
> On 2015/03/19 17:07:11, I haz the power (commit-bot) wrote:
> > Presubmit check for 1015173002-100001 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit ERRORS **
> > Since the CL is editing public API, you must have an LGTM from one of:
> > (mailto:, mailto:, mailto:,
> > mailto:, mailto:, mailto:)
> 
> Mike, can I get an lgtm for the changes to SkPaint?

Mike, can you ptal?

[joshualitt, 2015-03-20 15:11:25]

On 2015/03/20 14:46:58, joshualitt wrote:
> On 2015/03/19 17:11:23, joshualitt wrote:
> > On 2015/03/19 17:07:11, I haz the power (commit-bot) wrote:
> > > Presubmit check for 1015173002-100001 failed and returned exit status 1.
> > > 
> > > Running presubmit commit checks ...
> > > 
> > > ** Presubmit ERRORS **
> > > Since the CL is editing public API, you must have an LGTM from one of:
> > > (mailto:, mailto:, mailto:,
> > > mailto:, mailto:, mailto:)
> > 
> > Mike, can I get an lgtm for the changes to SkPaint?
> 
> Mike, can you ptal?

moved createTextContext to private

[reed1, 2015-03-20 15:28:27]

api lgtm

[joshualitt, 2015-03-20 17:17:53]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-03-20 17:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jvanverth@google.com, joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1015173002/#ps120001
(title: "move createTextContext to private")

[commit-bot: I haz the power, 2015-03-20 17:18:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015173002/120001

[commit-bot: I haz the power, 2015-03-20 17:30:18]

Committed patchset #6 (id:120001) as
https://skia.googlesource.com/skia/+/6e8cd9671958c69babde9338c5c18a4c3d895575