Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1015153002: Commit History transaction when app is backgrounded on iOS (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
droger
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Commit History transaction when app is backgrounded on iOS Request time from the OS when the application is backgrounded on iOS to try to commit all pending history transactions. BUG=429756 Committed: https://crrev.com/62bd9e3de2849b73f09d618cab31a03e072bcc73 Cr-Commit-Position: refs/heads/master@{#321329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M components/history/core/browser/history_backend.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M components/history/core/browser/history_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/history/core/browser/history_service.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
PTAL
5 years, 9 months ago (2015-03-18 17:26:47 UTC) #2
droger
lgtm It looks overkill to have both MakeCriticalClosure around the task, and a ScopedCriticalAction inside ...
5 years, 9 months ago (2015-03-18 18:07:09 UTC) #4
sdefresne
On 2015/03/18 18:07:09, droger wrote: > lgtm > > It looks overkill to have both ...
5 years, 9 months ago (2015-03-19 08:25:17 UTC) #5
sdefresne
sky: FYI, this is upstreaming iOS code
5 years, 9 months ago (2015-03-19 08:25:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015153002/20001
5 years, 9 months ago (2015-03-19 08:26:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-19 10:30:10 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:30:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62bd9e3de2849b73f09d618cab31a03e072bcc73
Cr-Commit-Position: refs/heads/master@{#321329}

Powered by Google App Engine
This is Rietveld 408576698