Add new helper VTTParser::collectDigitsToInt

Source/core/html/track/vtt/VTTRegion.cpp

 /*
  * Copyright (C) 2013 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 220 matching lines @@
     return None;
 }
 
 void VTTRegion::parseSettingValue(RegionSetting setting, const String& value)
 {
     DEFINE_STATIC_LOCAL(const AtomicString, scrollUpValueKeyword, ("up", AtomicString::ConstructFromLiteral));
 
     bool isValidSetting;
     String numberAsString;
     int number;
-    unsigned position;
     FloatPoint anchorPosition;
 
     switch (setting) {
     case Id:
         if (value.find("-->") == kNotFound)
             m_id = value;
         break;
     case Width:
         number = VTTParser::parseFloatPercentageValue(value, isValidSetting);
         if (isValidSetting)
             m_width = number;
         else
             WTF_LOG(Media, "VTTRegion::parseSettingValue, invalid Width");
         break;
-    case Height:
-        position = 0;
-
-        numberAsString = VTTParser::collectDigits(value, &position);
-        number = value.toInt(&isValidSetting);
-
-        if (isValidSetting && number >= 0)
+    case Height: {
+        unsigned position = 0;
+        if (VTTParser::collectDigitsToInt(value, &position, number) && position == value.length())
             m_heightInLines = number;
         else
             WTF_LOG(Media, "VTTRegion::parseSettingValue, invalid Height");
         break;
+    }

[Mike West, 2013/12/03 13:55:41]

Why did you add the '{' and '}'?

[jochen (gone - plz use gerrit), 2013/12/03 14:48:37]

So the unsigned position in line 256 is properly scoped I guess

     case RegionAnchor:
         anchorPosition = VTTParser::parseFloatPercentageValuePair(value, ',', isValidSetting);
         if (isValidSetting)
             m_regionAnchor = anchorPosition;
         else
             WTF_LOG(Media, "VTTRegion::parseSettingValue, invalid RegionAnchor");
         break;
     case ViewportAnchor:
         anchorPosition = VTTParser::parseFloatPercentageValuePair(value, ',', isValidSetting);
         if (isValidSetting)
@@ skipping 195 matching lines @@
 
 void VTTRegion::scrollTimerFired(Timer<VTTRegion>*)
 {
     WTF_LOG(Media, "VTTRegion::scrollTimerFired");
 
     stopTimer();
     displayLastTextTrackCueBox();
 }
 
 } // namespace WebCore