Extension window.create API accepts state.

chrome/browser/extensions/api/tabs/tabs_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 24 matching lines @@
 namespace extensions {
 
 namespace keys = tabs_constants;
 namespace utils = extension_function_test_utils;
 
 namespace {
 
 class ExtensionTabsTest : public InProcessBrowserTest {
 };
 
+class ExtensionWindowCreateTest : public InProcessBrowserTest {
+ public:
+  void SetUpOnMainThread() override;
+
+  // Run chrome.windows.create(). If success, return |true|.
+  bool RunCreateWindow(const std::string& args);
+
+ private:
+  scoped_refptr<Extension> extension_;
+};
+
+void ExtensionWindowCreateTest::SetUpOnMainThread() {
+  extension_ = test_util::CreateEmptyExtension();
 }
 
+bool ExtensionWindowCreateTest::RunCreateWindow(const std::string& args) {
+  scoped_refptr<WindowsCreateFunction> function(new WindowsCreateFunction());
+  function->set_extension(extension_.get());
+  return extensions::api_test_utils::RunFunction(function.get(), args,
+                                                 browser()->profile());
+}
+
+}  // namespace
+
 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetWindow) {
   int window_id = ExtensionTabUtil::GetWindowId(browser());
 
   // Invalid window ID error.
   scoped_refptr<WindowsGetFunction> function = new WindowsGetFunction();
   scoped_refptr<Extension> extension(test_util::CreateEmptyExtension());
   function->set_extension(extension.get());
   EXPECT_TRUE(MatchPattern(
       utils::RunFunctionAndReturnError(
           function.get(),
@@ skipping 497 matching lines @@
   function = new WindowsUpdateFunction();
   function->set_extension(extension.get());
   EXPECT_TRUE(MatchPattern(
       utils::RunFunctionAndReturnError(
           function.get(),
           base::StringPrintf(kArgsMaximizedWithBounds, window_id),
           browser()),
       keys::kInvalidWindowStateError));
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionWindowCreateTest, ValidateCreateWindowState) {
+  EXPECT_TRUE(RunCreateWindow("[{\"state\": \"fullscreen\"}]"));

[not at google - send to devlin, 2015/03/19 17:56:31]

What is this testing?

If anything I would have thought you need to look up the update() tests and see
how it tests fullscreen/minimized/etc, and possibly adapt those for create().

[limasdf, 2015/03/20 17:03:46]

Done. But fullscreen test is added only. It looks like BaseWindow::Maximized,
BaseWindow::IsMaxmized doesn't work properly. this is same in window.update
funciton as well.

plus, I'll add more test from next CL(Validate param).

+  EXPECT_TRUE(RunCreateWindow("[{\"state\": \"maximized\"}]"));
+  EXPECT_TRUE(RunCreateWindow("[{\"state\": \"minimized\"}]"));
+  EXPECT_TRUE(RunCreateWindow("[{\"state\": \"normal\"}]"));
+}
+
 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DuplicateTab) {
   content::OpenURLParams params(GURL(url::kAboutBlankURL),
                                 content::Referrer(),
                                 NEW_FOREGROUND_TAB,
                                 ui::PAGE_TRANSITION_LINK,
                                 false);
   content::WebContents* web_contents = browser()->OpenURL(params);
   int tab_id = ExtensionTabUtil::GetTabId(web_contents);
   int window_id = ExtensionTabUtil::GetWindowIdOfTab(web_contents);
   int tab_index = -1;
@@ skipping 420 matching lines @@
   // Test chrome.tabs.setZoom().
   error = RunSetZoomExpectError(tab_id, 3.14159);
   EXPECT_TRUE(MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 
   // chrome.tabs.setZoomSettings().
   error = RunSetZoomSettingsExpectError(tab_id, "manual", "per-tab");
   EXPECT_TRUE(MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 }
 
 }  // namespace extensions